Skip to content

Conversation

@lsy3993
Copy link
Contributor

@lsy3993 lsy3993 commented May 16, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #30929

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented May 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@lsy3993
Copy link
Contributor Author

lsy3993 commented May 16, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49806 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3342e6019613f870ede3e12c04bcad19fcebe1e9, data reload: false

------ Round 1 ----------------------------------
q1	17672	4454	4350	4350
q2	2092	156	158	156
q3	10503	1945	1942	1942
q4	10358	1266	1343	1266
q5	8623	4048	3998	3998
q6	231	125	125	125
q7	2055	1624	1621	1621
q8	9272	2771	2757	2757
q9	10489	10239	10060	10060
q10	8650	3552	3555	3552
q11	427	251	252	251
q12	476	306	307	306
q13	18364	4012	4020	4012
q14	355	328	326	326
q15	514	459	460	459
q16	547	454	468	454
q17	1147	971	973	971
q18	7238	6888	6861	6861
q19	1733	1591	1485	1485
q20	537	341	295	295
q21	4466	4240	4166	4166
q22	487	393	406	393
Total cold run time: 116236 ms
Total hot run time: 49806 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4370	4304	4303	4303
q2	326	235	226	226
q3	4207	4163	4144	4144
q4	2763	2747	2754	2747
q5	7170	7177	7205	7177
q6	240	125	120	120
q7	3256	2814	2812	2812
q8	4394	4460	4431	4431
q9	14232	14255	13800	13800
q10	4228	4270	4295	4270
q11	737	680	668	668
q12	1016	845	830	830
q13	7257	3747	3712	3712
q14	443	436	422	422
q15	504	467	458	458
q16	639	586	592	586
q17	3984	3799	3752	3752
q18	8842	8667	8831	8667
q19	1739	1714	1658	1658
q20	2340	2113	2096	2096
q21	8378	8412	8333	8333
q22	988	922	947	922
Total cold run time: 82053 ms
Total hot run time: 76134 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.56% (8312/21555)
Line Coverage 30.26% (68755/227210)
Region Coverage 29.68% (35404/119274)
Branch Coverage 25.44% (18197/71528)

@doris-robot
Copy link

TPC-DS: Total hot run time: 213768 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3342e6019613f870ede3e12c04bcad19fcebe1e9, data reload: false

query1	939	394	404	394
query2	6562	2259	2334	2259
query3	6922	204	203	203
query4	23270	21481	21883	21481
query5	19765	6499	6532	6499
query6	295	222	253	222
query7	4329	301	326	301
query8	240	275	255	255
query9	3077	2633	2553	2553
query10	464	318	300	300
query11	16395	15013	14941	14941
query12	136	81	78	78
query13	1043	459	435	435
query14	17353	13411	13905	13411
query15	377	215	222	215
query16	6476	283	261	261
query17	1779	944	879	879
query18	895	313	313	313
query19	223	151	158	151
query20	95	95	97	95
query21	194	99	96	96
query22	5310	5171	5086	5086
query23	34194	33459	33539	33459
query24	7879	6348	6356	6348
query25	526	462	438	438
query26	1271	173	161	161
query27	2392	297	293	293
query28	6124	2276	2237	2237
query29	2943	2814	2685	2685
query30	247	168	169	168
query31	973	731	734	731
query32	74	62	58	58
query33	453	251	267	251
query34	869	465	471	465
query35	1128	945	863	863
query36	1277	1153	1108	1108
query37	169	61	60	60
query38	3063	2945	2895	2895
query39	1372	1329	1330	1329
query40	306	94	93	93
query41	41	39	42	39
query42	85	88	88	88
query43	718	606	679	606
query44	1136	715	718	715
query45	248	230	238	230
query46	1226	943	974	943
query47	2062	1880	1806	1806
query48	520	423	402	402
query49	668	382	393	382
query50	847	622	617	617
query51	4737	4700	4698	4698
query52	94	85	90	85
query53	234	189	197	189
query54	2649	2492	2490	2490
query55	85	74	84	74
query56	228	203	195	195
query57	1225	1179	1128	1128
query58	222	218	223	218
query59	3733	3291	3548	3291
query60	212	211	199	199
query61	98	98	95	95
query62	911	452	469	452
query63	201	181	173	173
query64	3500	1612	1512	1512
query65	3640	3580	3535	3535
query66	768	422	414	414
query67	17009	16196	16116	16116
query68	8841	665	642	642
query69	495	277	283	277
query70	1469	1529	1278	1278
query71	409	315	304	304
query72	6774	4916	4858	4858
query73	754	321	320	320
query74	6225	5850	5797	5797
query75	4696	3680	3719	3680
query76	4562	1168	1194	1168
query77	546	254	264	254
query78	12786	11731	11642	11642
query79	8998	659	654	654
query80	2550	411	384	384
query81	504	235	235	235
query82	1638	94	99	94
query83	164	136	137	136
query84	259	71	70	70
query85	1228	319	316	316
query86	360	294	288	288
query87	3247	3073	3015	3015
query88	4886	2343	2335	2335
query89	493	281	278	278
query90	1872	208	218	208
query91	162	136	130	130
query92	56	53	50	50
query93	7119	584	563	563
query94	868	209	214	209
query95	2003	1998	2011	1998
query96	634	328	319	319
query97	6614	6423	6533	6423
query98	220	209	194	194
query99	3001	940	887	887
Total cold run time: 322929 ms
Total hot run time: 213768 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.35 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3342e6019613f870ede3e12c04bcad19fcebe1e9, data reload: false

query1	0.03	0.02	0.03
query2	0.07	0.02	0.02
query3	0.24	0.05	0.05
query4	1.76	0.05	0.06
query5	0.53	0.53	0.53
query6	1.34	0.63	0.60
query7	0.01	0.01	0.01
query8	0.04	0.02	0.03
query9	0.53	0.47	0.48
query10	0.53	0.55	0.53
query11	0.12	0.08	0.09
query12	0.12	0.09	0.09
query13	0.62	0.61	0.62
query14	0.79	0.77	0.78
query15	0.78	0.76	0.75
query16	0.37	0.38	0.35
query17	1.00	0.99	1.02
query18	0.22	0.23	0.25
query19	1.87	1.85	1.87
query20	0.01	0.01	0.01
query21	15.46	0.53	0.54
query22	2.16	2.44	1.82
query23	17.29	1.06	1.00
query24	4.54	4.31	1.14
query25	0.38	0.10	0.06
query26	0.78	0.17	0.16
query27	0.05	0.05	0.05
query28	5.18	0.81	0.78
query29	12.65	2.37	2.35
query30	0.60	0.56	0.58
query31	2.81	0.39	0.37
query32	3.37	0.50	0.49
query33	3.07	3.07	3.06
query34	15.28	4.83	4.83
query35	4.85	4.86	4.86
query36	1.05	1.01	1.01
query37	0.06	0.04	0.05
query38	0.03	0.02	0.02
query39	0.02	0.01	0.01
query40	0.16	0.14	0.14
query41	0.07	0.01	0.01
query42	0.02	0.01	0.01
query43	0.03	0.02	0.02
Total cold run time: 100.89 s
Total hot run time: 31.35 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 3342e6019613f870ede3e12c04bcad19fcebe1e9 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       22.1 seconds inserted 10000000 Rows, about 452K ops/s

@lsy3993
Copy link
Contributor Author

lsy3993 commented May 17, 2025

run external

@lsy3993
Copy link
Contributor Author

lsy3993 commented May 17, 2025

run p0

@lsy3993
Copy link
Contributor Author

lsy3993 commented May 17, 2025

run external

1 similar comment
@lsy3993
Copy link
Contributor Author

lsy3993 commented May 17, 2025

run external

@lsy3993
Copy link
Contributor Author

lsy3993 commented May 17, 2025

run p0

@lsy3993
Copy link
Contributor Author

lsy3993 commented May 17, 2025

run external

@lsy3993
Copy link
Contributor Author

lsy3993 commented May 17, 2025

run p0

1 similar comment
@lsy3993
Copy link
Contributor Author

lsy3993 commented May 19, 2025

run p0

@lsy3993
Copy link
Contributor Author

lsy3993 commented May 19, 2025

run external

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 23, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@lsy3993
Copy link
Contributor Author

lsy3993 commented May 28, 2025

run p0

@lsy3993
Copy link
Contributor Author

lsy3993 commented May 28, 2025

run beut

@lsy3993
Copy link
Contributor Author

lsy3993 commented May 28, 2025

run external

@lsy3993
Copy link
Contributor Author

lsy3993 commented May 28, 2025

run beut

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.57% (8314/21555)
Line Coverage 30.27% (68778/227210)
Region Coverage 29.70% (35420/119274)
Branch Coverage 25.45% (18205/71528)

@lsy3993 lsy3993 closed this Jun 9, 2025
@lsy3993 lsy3993 deleted the fix_function branch June 9, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants