-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[fix](export) The export task thread pool uses a blocking queue strategy #51609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 49676 ms |
TPC-DS: Total hot run time: 213227 ms |
ClickBench: Total hot run time: 30.86 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
What problem does this PR solve?
When export parallelism exceeds
maximum_parallelism_of_export_job, excess tasks are discarded byLogDiscardPolicy.Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
newDaemonCacheThreadPoolwithnewDaemonFixedThreadPoolto use blocking queue instead of discard policymax(parallelNum, maximum_parallelism_of_export_job)to ensure all tasks can be queuedexec()method for dynamic sizingRelease note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)