Skip to content

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Nov 13, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Nov 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring
Copy link
Contributor

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 13, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 34282 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 32315ac713ae77cac58f58b473a49bc3882d9adf, data reload: false

------ Round 1 ----------------------------------
q1	17654	5206	5024	5024
q2	2034	320	215	215
q3	10236	1292	710	710
q4	10233	883	372	372
q5	7519	2367	2339	2339
q6	190	173	139	139
q7	912	765	655	655
q8	9366	1329	1114	1114
q9	6999	5118	5149	5118
q10	6853	2186	1814	1814
q11	480	298	293	293
q12	359	364	234	234
q13	17770	3612	3052	3052
q14	230	235	216	216
q15	560	504	499	499
q16	990	994	972	972
q17	597	846	363	363
q18	7591	7074	7073	7073
q19	1341	946	571	571
q20	337	335	242	242
q21	3713	3226	2296	2296
q22	1077	1043	971	971
Total cold run time: 107041 ms
Total hot run time: 34282 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5098	5085	5074	5074
q2	248	328	234	234
q3	2138	2711	2293	2293
q4	1346	1766	1323	1323
q5	4205	4388	4448	4388
q6	210	177	136	136
q7	2079	2005	1748	1748
q8	2707	2557	2542	2542
q9	7296	7324	7372	7324
q10	3047	3230	2932	2932
q11	592	527	501	501
q12	709	796	892	796
q13	3426	3909	3433	3433
q14	291	310	291	291
q15	566	503	513	503
q16	1100	1102	1095	1095
q17	1198	1581	1384	1384
q18	7760	7687	7636	7636
q19	817	833	923	833
q20	2016	2132	1866	1866
q21	4640	4303	4421	4303
q22	1091	1063	987	987
Total cold run time: 52580 ms
Total hot run time: 51622 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188547 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 32315ac713ae77cac58f58b473a49bc3882d9adf, data reload: false

query1	1020	409	400	400
query2	6575	1700	1772	1700
query3	6770	230	223	223
query4	26639	23431	23398	23398
query5	4406	651	479	479
query6	358	250	235	235
query7	4648	506	298	298
query8	315	258	257	257
query9	8734	2617	2612	2612
query10	473	352	296	296
query11	15742	15173	14993	14993
query12	187	119	117	117
query13	1692	583	436	436
query14	11249	9404	9271	9271
query15	198	195	182	182
query16	7687	682	533	533
query17	1259	774	654	654
query18	2044	431	334	334
query19	227	212	188	188
query20	130	125	123	123
query21	223	134	118	118
query22	3990	4160	4071	4071
query23	34142	33071	33171	33071
query24	8460	2467	2465	2465
query25	622	546	477	477
query26	1288	275	164	164
query27	2735	491	364	364
query28	4364	2219	2201	2201
query29	785	619	482	482
query30	301	228	201	201
query31	929	790	721	721
query32	94	75	75	75
query33	606	366	325	325
query34	798	834	549	549
query35	802	821	752	752
query36	939	1054	897	897
query37	120	116	92	92
query38	3525	3529	3463	3463
query39	1520	1404	1438	1404
query40	221	133	120	120
query41	62	63	63	63
query42	130	117	115	115
query43	496	509	478	478
query44	1227	754	743	743
query45	194	183	176	176
query46	881	986	653	653
query47	1714	1786	1716	1716
query48	411	425	319	319
query49	775	516	461	461
query50	658	675	411	411
query51	3887	4056	3902	3902
query52	113	123	113	113
query53	264	279	190	190
query54	313	291	275	275
query55	89	87	89	87
query56	340	326	327	326
query57	1191	1194	1109	1109
query58	287	281	267	267
query59	2528	2661	2560	2560
query60	342	350	335	335
query61	159	174	163	163
query62	789	733	673	673
query63	235	203	200	200
query64	4473	1164	872	872
query65	4041	3934	3985	3934
query66	1087	461	335	335
query67	15176	15023	14893	14893
query68	8419	896	593	593
query69	481	330	293	293
query70	1385	1355	1243	1243
query71	475	342	323	323
query72	6081	4950	5025	4950
query73	722	651	359	359
query74	9098	9109	8824	8824
query75	3870	3307	2746	2746
query76	3734	1161	730	730
query77	814	397	300	300
query78	9415	9777	8884	8884
query79	1950	792	592	592
query80	650	573	496	496
query81	485	265	235	235
query82	420	161	130	130
query83	270	266	252	252
query84	249	104	93	93
query85	902	482	430	430
query86	338	312	292	292
query87	3707	3768	3658	3658
query88	2887	2321	2284	2284
query89	389	334	293	293
query90	1984	220	219	219
query91	166	168	138	138
query92	83	65	63	63
query93	1095	975	652	652
query94	714	457	365	365
query95	416	325	324	324
query96	499	569	286	286
query97	2924	2976	2876	2876
query98	240	215	214	214
query99	1433	1385	1300	1300
Total cold run time: 274974 ms
Total hot run time: 188547 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.52 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 32315ac713ae77cac58f58b473a49bc3882d9adf, data reload: false

query1	0.05	0.04	0.05
query2	0.10	0.05	0.05
query3	0.25	0.08	0.08
query4	1.61	0.12	0.11
query5	0.26	0.26	0.26
query6	1.17	0.66	0.63
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.58	0.54	0.52
query10	0.58	0.57	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.60
query14	1.00	1.00	1.00
query15	0.84	0.84	0.83
query16	0.38	0.40	0.39
query17	1.05	1.01	1.00
query18	0.22	0.20	0.21
query19	1.94	1.84	1.84
query20	0.02	0.01	0.02
query21	15.44	0.21	0.13
query22	4.90	0.07	0.05
query23	15.66	0.26	0.10
query24	2.81	0.56	0.30
query25	0.07	0.06	0.05
query26	0.14	0.13	0.14
query27	0.08	0.05	0.05
query28	3.46	1.13	0.93
query29	12.55	3.86	3.27
query30	0.29	0.14	0.11
query31	2.82	0.60	0.38
query32	3.24	0.56	0.47
query33	3.03	3.08	3.08
query34	15.81	5.19	4.61
query35	4.57	4.58	4.60
query36	0.69	0.51	0.49
query37	0.10	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.14
query41	0.08	0.04	0.03
query42	0.03	0.03	0.04
query43	0.04	0.03	0.04
Total cold run time: 97.14 s
Total hot run time: 27.52 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.81% (18285/34621)
Line Coverage 38.19% (166275/435441)
Region Coverage 33.18% (129247/389583)
Branch Coverage 33.91% (55466/163574)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 22.22% (2/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.59% (24354/34021)
Line Coverage 58.07% (253239/436117)
Region Coverage 53.50% (211379/395094)
Branch Coverage 54.80% (90231/164649)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants