Skip to content

[fix](nereids) make needsFinalize false for distinct agg local phase #58460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2025
Merged

[fix](nereids) make needsFinalize false for distinct agg local phase #58460

merged 2 commits into from
Nov 28, 2025

Conversation

@feiniaofeiafei
Copy link
Contributor

@feiniaofeiafei feiniaofeiafei commented Nov 27, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Nov 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@feiniaofeiafei
Copy link
Contributor Author

feiniaofeiafei commented Nov 27, 2025

run buildall

@feiniaofeiafei
Copy link
Contributor Author

feiniaofeiafei commented Nov 27, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 27, 2025

TPC-H: Total hot run time: 34384 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d48e82296a6d1560009ab58ee5429578b1bac982, data reload: false

------ Round 1 ----------------------------------
q1	17698	5044	4947	4947
q2	2071	325	208	208
q3	10230	1294	751	751
q4	10293	884	378	378
q5	7566	2548	2265	2265
q6	185	169	137	137
q7	979	817	658	658
q8	9354	1342	1095	1095
q9	6844	5324	5333	5324
q10	6877	2242	1826	1826
q11	508	319	284	284
q12	333	382	232	232
q13	17782	3715	2984	2984
q14	230	234	221	221
q15	593	513	514	513
q16	894	883	796	796
q17	578	791	497	497
q18	7990	7139	6980	6980
q19	1103	956	581	581
q20	360	353	229	229
q21	4006	3467	2560	2560
q22	1055	990	918	918
Total cold run time: 107529 ms
Total hot run time: 34384 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4984	4970	4999	4970
q2	327	393	316	316
q3	2169	2698	2305	2305
q4	1307	1761	1357	1357
q5	4262	4541	4470	4470
q6	211	189	142	142
q7	2096	2031	1872	1872
q8	2677	2481	2512	2481
q9	7464	7550	7501	7501
q10	3060	3306	2795	2795
q11	588	523	499	499
q12	717	774	581	581
q13	3618	3909	3329	3329
q14	286	301	267	267
q15	573	522	501	501
q16	923	920	881	881
q17	1183	1435	1578	1435
q18	7656	7732	7717	7717
q19	810	760	839	760
q20	2043	2080	1940	1940
q21	4862	4448	4234	4234
q22	1025	1075	962	962
Total cold run time: 52841 ms
Total hot run time: 51315 ms

@doris-robot
Copy link

doris-robot commented Nov 27, 2025

TPC-DS: Total hot run time: 182262 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d48e82296a6d1560009ab58ee5429578b1bac982, data reload: false

query1	1030	413	387	387
query2	6605	1580	1558	1558
query3	6766	235	225	225
query4	25327	23181	23037	23037
query5	5095	629	480	480
query6	358	235	219	219
query7	4669	502	302	302
query8	307	281	259	259
query9	8730	2584	2587	2584
query10	556	345	313	313
query11	15411	15085	14894	14894
query12	184	121	118	118
query13	1687	565	439	439
query14	9451	5600	5588	5588
query15	208	210	184	184
query16	7683	685	511	511
query17	1186	755	613	613
query18	2038	415	326	326
query19	216	207	180	180
query20	129	127	120	120
query21	225	141	112	112
query22	3911	4050	3837	3837
query23	32852	31997	32082	31997
query24	8525	2416	2448	2416
query25	656	529	448	448
query26	1240	270	164	164
query27	2766	492	351	351
query28	4345	2139	2122	2122
query29	807	633	511	511
query30	308	243	212	212
query31	845	712	646	646
query32	84	77	74	74
query33	598	391	333	333
query34	815	872	560	560
query35	840	843	741	741
query36	886	938	834	834
query37	121	106	89	89
query38	3877	3879	3790	3790
query39	1468	1587	1443	1443
query40	226	130	118	118
query41	69	63	65	63
query42	123	122	115	115
query43	429	451	419	419
query44	1295	767	757	757
query45	213	198	184	184
query46	871	1005	648	648
query47	1679	1693	1649	1649
query48	398	425	329	329
query49	760	481	415	415
query50	666	696	425	425
query51	3897	4008	3809	3809
query52	109	114	110	110
query53	250	264	196	196
query54	303	290	281	281
query55	98	95	96	95
query56	347	341	318	318
query57	1149	1158	1099	1099
query58	305	293	281	281
query59	2395	2412	2330	2330
query60	382	367	367	367
query61	195	192	188	188
query62	788	739	685	685
query63	245	206	204	204
query64	4578	1195	881	881
query65	4051	3959	3939	3939
query66	1093	438	335	335
query67	15010	14970	14677	14677
query68	5280	964	629	629
query69	521	343	315	315
query70	1121	1076	1003	1003
query71	411	350	319	319
query72	5739	4798	4968	4798
query73	652	585	354	354
query74	8697	8907	8617	8617
query75	3112	3095	2585	2585
query76	3355	1143	719	719
query77	514	425	338	338
query78	9383	9745	9013	9013
query79	1443	890	592	592
query80	1714	634	544	544
query81	556	272	242	242
query82	426	149	118	118
query83	372	277	267	267
query84	275	125	103	103
query85	1034	488	454	454
query86	392	314	295	295
query87	4062	4090	4085	4085
query88	3004	2355	2330	2330
query89	392	335	303	303
query90	1731	234	234	234
query91	171	176	146	146
query92	72	72	70	70
query93	1141	1010	667	667
query94	728	461	347	347
query95	510	411	407	407
query96	535	568	294	294
query97	2616	2672	2620	2620
query98	233	222	214	214
query99	1280	1413	1306	1306
Total cold run time: 266201 ms
Total hot run time: 182262 ms

@doris-robot
Copy link

doris-robot commented Nov 27, 2025

ClickBench: Total hot run time: 27.59 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d48e82296a6d1560009ab58ee5429578b1bac982, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.25	0.09	0.09
query4	1.60	0.11	0.10
query5	0.28	0.26	0.26
query6	1.17	0.66	0.63
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.57	0.51	0.50
query10	0.54	0.55	0.56
query11	0.15	0.11	0.12
query12	0.14	0.12	0.11
query13	0.63	0.60	0.61
query14	0.99	1.01	0.99
query15	0.83	0.80	0.81
query16	0.42	0.40	0.40
query17	1.06	1.02	1.02
query18	0.24	0.22	0.21
query19	1.96	1.87	1.86
query20	0.02	0.02	0.02
query21	15.48	0.29	0.14
query22	4.64	0.05	0.04
query23	16.05	0.28	0.10
query24	1.42	0.50	0.68
query25	0.12	0.08	0.07
query26	0.13	0.14	0.13
query27	0.10	0.04	0.05
query28	4.90	1.21	1.03
query29	12.61	3.91	3.19
query30	0.28	0.14	0.12
query31	2.82	0.60	0.40
query32	3.25	0.55	0.46
query33	3.00	3.06	3.10
query34	17.02	5.23	4.53
query35	4.57	4.58	4.53
query36	0.67	0.51	0.48
query37	0.10	0.07	0.06
query38	0.07	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.14	0.14
query41	0.09	0.04	0.04
query42	0.04	0.02	0.02
query43	0.05	0.03	0.04
Total cold run time: 98.71 s
Total hot run time: 27.59 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 27, 2025

FE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 27, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit e60d31d into apache:master Nov 28, 2025
28 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 28, 2025
@feiniaofeiafei
[fix](nereids) make needsFinalize false for distinct agg local phase (#…
9d855e5 
…58460)
@github-actions github-actions bot mentioned this pull request Nov 28, 2025
Merged
yiguolei pushed a commit that referenced this pull request Nov 28, 2025
@github-actions @feiniaofeiafei
branch-4.0: [fix](nereids) make needsFinalize false for distinct agg …
a6b5303 
…local phase #58460 (#58489)

Cherry-picked from #58460

Co-authored-by: feiniaofeiafei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@924060929 924060929 924060929 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@feiniaofeiafei @Thearas @doris-robot @hello-stephen @924060929 @morrySnow @yiguolei