-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[bug](parquet) fix parquet type not handle float16 type #58528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34499 ms |
TPC-DS: Total hot run time: 181688 ms |
ClickBench: Total hot run time: 27.35 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 34198 ms |
TPC-DS: Total hot run time: 182183 ms |
ClickBench: Total hot run time: 27.18 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
2 similar comments
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
hubgeter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
run buildall |
TPC-DS: Total hot run time: 180849 ms |
ClickBench: Total hot run time: 27.42 s |
|
run buildall |
TPC-H: Total hot run time: 34206 ms |
TPC-DS: Total hot run time: 182177 ms |
ClickBench: Total hot run time: 27.31 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hubgeter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
### What problem does this PR solve?
Problem Summary:
before not deal with float16 type, so it's mapping to string type, and
the result is invaild eg:
```
mysql> select * from HDFS("uri" = "hdfs://127.0.0.1:8020/user/doris/tvf_data/test_hdfs_parquet/group0/float16_nonzeros_and_nans.parquet", "hadoop.username" = "doris", "format" = "parquet");
+------+
| x |
+------+
| NULL |
| < |
| � |
| ~ |
| |
| � |
| � |
| @ |
+------+
```
but it's could mapping to float type, eg:
```
mysql> select x from file( "fs.local.support" = "true", "file_path" = "float16_nonzeros_and_nans.parquet", "format" = "parquet",'shared_storage'='true' );
+------+
| x |
+------+
| NULL |
| 1 |
| -2 |
| NaN |
| 0 |
| -1 |
| -0 |
| 2 |
+------+
```
What problem does this PR solve?
Problem Summary:
before not deal with float16 type, so it's mapping to string type, and the result is invaild eg:
but it's could mapping to float type, eg:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)