Skip to content

Conversation

@zhangstar333
Copy link
Contributor

What problem does this PR solve?

Problem Summary:
before not deal with float16 type, so it's mapping to string type, and the result is invaild eg:

mysql> select * from HDFS("uri" = "hdfs://127.0.0.1:8020/user/doris/tvf_data/test_hdfs_parquet/group0/float16_nonzeros_and_nans.parquet",                         "hadoop.username" = "doris",                         "format" = "parquet");
+------+
| x    |
+------+
| NULL |
|  <   |
|  �    |
|  ~   |
|      |
|  �    |
|  �    |
|  @   |
+------+

but it's could mapping to float type, eg:

mysql>  select x from file(     "fs.local.support" = "true",     "file_path" = "float16_nonzeros_and_nans.parquet",    "format" = "parquet",'shared_storage'='true' );
+------+
| x    |
+------+
| NULL |
|    1 |
|   -2 |
|  NaN |
|    0 |
|   -1 |
|   -0 |
|    2 |
+------+

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Nov 29, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34499 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5a579286c6d49655105315ba5cbd3c0550bf536b, data reload: false

------ Round 1 ----------------------------------
q1	17651	5047	4956	4956
q2	2010	321	215	215
q3	10243	1305	754	754
q4	10209	862	368	368
q5	7540	2544	2235	2235
q6	189	175	142	142
q7	963	795	654	654
q8	9357	1415	1097	1097
q9	7165	5337	5348	5337
q10	6922	2238	1825	1825
q11	510	315	295	295
q12	398	378	229	229
q13	17775	3691	3057	3057
q14	236	240	219	219
q15	594	519	514	514
q16	894	876	807	807
q17	614	754	533	533
q18	8164	7083	7112	7083
q19	1093	981	584	584
q20	350	345	232	232
q21	3913	3487	2426	2426
q22	1011	1009	937	937
Total cold run time: 107801 ms
Total hot run time: 34499 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5023	4944	4968	4944
q2	333	407	341	341
q3	2156	2698	2311	2311
q4	1299	1760	1294	1294
q5	4272	4587	4496	4496
q6	222	183	130	130
q7	2114	2022	1866	1866
q8	2699	2515	2489	2489
q9	7527	7429	7531	7429
q10	3071	3216	2889	2889
q11	616	510	504	504
q12	703	762	613	613
q13	3541	3954	3536	3536
q14	301	309	275	275
q15	558	527	522	522
q16	876	951	905	905
q17	1223	1442	1491	1442
q18	7868	7693	7624	7624
q19	818	837	854	837
q20	2045	2124	1960	1960
q21	4715	4296	4100	4100
q22	1110	1045	996	996
Total cold run time: 53090 ms
Total hot run time: 51503 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 181688 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5a579286c6d49655105315ba5cbd3c0550bf536b, data reload: false

query1	1033	415	395	395
query2	6640	1231	1205	1205
query3	6755	225	232	225
query4	25424	23403	22940	22940
query5	4840	651	513	513
query6	353	232	216	216
query7	4650	515	320	320
query8	322	275	244	244
query9	8719	2598	2612	2598
query10	539	369	301	301
query11	15550	15053	14508	14508
query12	191	127	115	115
query13	1691	585	455	455
query14	9614	6068	6032	6032
query15	215	208	188	188
query16	7441	710	536	536
query17	1228	783	648	648
query18	2023	438	342	342
query19	216	209	195	195
query20	132	130	132	130
query21	234	147	118	118
query22	3834	4073	3886	3886
query23	33051	31968	31860	31860
query24	8562	2458	2421	2421
query25	650	557	506	506
query26	1252	281	175	175
query27	2732	499	371	371
query28	4322	2146	2135	2135
query29	877	688	537	537
query30	314	246	213	213
query31	835	739	619	619
query32	90	84	81	81
query33	606	388	358	358
query34	829	875	562	562
query35	824	859	742	742
query36	876	934	794	794
query37	117	109	83	83
query38	3851	3789	3849	3789
query39	1466	1421	1402	1402
query40	234	129	117	117
query41	64	60	59	59
query42	124	114	117	114
query43	450	459	424	424
query44	1299	755	751	751
query45	197	192	184	184
query46	871	1003	656	656
query47	1703	1717	1673	1673
query48	404	438	336	336
query49	751	491	433	433
query50	688	701	425	425
query51	3918	3881	3859	3859
query52	114	116	104	104
query53	235	267	196	196
query54	314	291	283	283
query55	97	91	93	91
query56	320	327	324	324
query57	1135	1186	1107	1107
query58	293	269	273	269
query59	2352	2426	2334	2334
query60	350	351	344	344
query61	164	155	171	155
query62	804	779	629	629
query63	246	196	192	192
query64	4624	1259	877	877
query65	4065	3988	4000	3988
query66	1154	443	337	337
query67	15214	15257	14921	14921
query68	8471	965	623	623
query69	515	343	314	314
query70	1092	999	989	989
query71	472	329	314	314
query72	5833	4792	4768	4768
query73	683	576	346	346
query74	8835	8706	8578	8578
query75	3622	3026	2509	2509
query76	3742	1141	738	738
query77	823	403	316	316
query78	9510	9587	9006	9006
query79	2196	835	591	591
query80	643	586	483	483
query81	503	273	242	242
query82	455	135	114	114
query83	262	255	250	250
query84	272	110	96	96
query85	987	502	439	439
query86	394	314	287	287
query87	4009	4072	3967	3967
query88	4093	2315	2277	2277
query89	400	330	301	301
query90	1919	227	222	222
query91	173	172	147	147
query92	89	76	68	68
query93	1880	1001	673	673
query94	716	464	352	352
query95	508	414	421	414
query96	516	548	283	283
query97	2646	2714	2570	2570
query98	249	219	214	214
query99	1328	1400	1257	1257
Total cold run time: 272918 ms
Total hot run time: 181688 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.35 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5a579286c6d49655105315ba5cbd3c0550bf536b, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.04	0.04
query3	0.25	0.09	0.09
query4	1.61	0.11	0.10
query5	0.27	0.27	0.26
query6	1.16	0.64	0.64
query7	0.03	0.02	0.03
query8	0.05	0.04	0.05
query9	0.57	0.51	0.51
query10	0.57	0.57	0.56
query11	0.15	0.11	0.12
query12	0.14	0.11	0.12
query13	0.63	0.60	0.60
query14	0.99	0.99	0.99
query15	0.81	0.80	0.80
query16	0.38	0.39	0.42
query17	0.99	1.07	1.07
query18	0.23	0.22	0.21
query19	1.98	1.87	1.84
query20	0.01	0.01	0.02
query21	15.44	0.28	0.14
query22	4.87	0.05	0.04
query23	16.32	0.26	0.11
query24	0.94	0.46	0.22
query25	0.07	0.05	0.04
query26	0.14	0.14	0.15
query27	0.07	0.05	0.05
query28	3.06	1.22	1.04
query29	12.58	3.92	3.20
query30	0.28	0.14	0.12
query31	2.81	0.59	0.39
query32	3.24	0.55	0.47
query33	3.02	3.10	3.05
query34	17.02	5.16	4.52
query35	4.58	4.58	4.53
query36	0.66	0.49	0.50
query37	0.11	0.07	0.06
query38	0.07	0.04	0.04
query39	0.05	0.03	0.03
query40	0.18	0.15	0.14
query41	0.08	0.03	0.03
query42	0.05	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 96.66 s
Total hot run time: 27.35 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 8.33% (4/48) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.90% (18513/34998)
Line Coverage 38.45% (169664/441233)
Region Coverage 33.23% (131662/396189)
Branch Coverage 34.19% (56700/165831)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 8.33% (4/48) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.66% (24591/34316)
Line Coverage 58.20% (256590/440840)
Region Coverage 53.24% (213499/401001)
Branch Coverage 54.80% (91362/166728)

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34198 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 87aaf1ecb0025b2b7dc1979a8916aa54b471ec3d, data reload: false

------ Round 1 ----------------------------------
q1	17624	5121	4971	4971
q2	2024	339	213	213
q3	10221	1316	731	731
q4	10232	893	328	328
q5	7795	2428	2148	2148
q6	215	168	136	136
q7	935	774	643	643
q8	9361	1329	1060	1060
q9	7406	5290	5395	5290
q10	6859	2191	1806	1806
q11	526	318	291	291
q12	378	379	244	244
q13	17794	3657	3054	3054
q14	238	248	209	209
q15	593	520	515	515
q16	889	863	823	823
q17	613	774	510	510
q18	7614	7168	7118	7118
q19	1090	957	586	586
q20	342	354	241	241
q21	3768	3254	2329	2329
q22	1016	979	952	952
Total cold run time: 107533 ms
Total hot run time: 34198 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4993	4937	4841	4841
q2	312	397	329	329
q3	2125	2695	2280	2280
q4	1362	1741	1283	1283
q5	4205	4431	4623	4431
q6	224	174	131	131
q7	2090	1998	1849	1849
q8	2617	2497	2520	2497
q9	7550	7500	7695	7500
q10	3146	3259	2812	2812
q11	600	525	506	506
q12	689	754	655	655
q13	3496	3874	3383	3383
q14	308	311	283	283
q15	557	513	514	513
q16	939	950	869	869
q17	1240	1408	1419	1408
q18	7949	7663	7628	7628
q19	827	780	840	780
q20	2039	2136	1930	1930
q21	4841	4487	4104	4104
q22	1052	1034	1012	1012
Total cold run time: 53161 ms
Total hot run time: 51024 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 182183 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 87aaf1ecb0025b2b7dc1979a8916aa54b471ec3d, data reload: false

query1	1079	409	389	389
query2	6583	1185	1185	1185
query3	6748	230	226	226
query4	25889	23342	22913	22913
query5	4939	665	490	490
query6	360	243	235	235
query7	4656	516	314	314
query8	312	281	249	249
query9	8751	2671	2645	2645
query10	543	373	321	321
query11	15310	15211	14859	14859
query12	184	119	120	119
query13	1691	564	456	456
query14	9585	5946	5946	5946
query15	218	199	181	181
query16	7579	720	509	509
query17	1233	748	594	594
query18	2032	420	323	323
query19	202	201	175	175
query20	134	136	119	119
query21	217	135	117	117
query22	3961	3942	3834	3834
query23	32975	32326	31917	31917
query24	8533	2430	2394	2394
query25	636	525	451	451
query26	1247	274	165	165
query27	2739	499	342	342
query28	4343	2174	2157	2157
query29	795	619	481	481
query30	315	238	222	222
query31	836	706	631	631
query32	78	80	76	76
query33	601	375	336	336
query34	824	888	546	546
query35	780	830	746	746
query36	895	931	830	830
query37	124	108	90	90
query38	3869	3842	3813	3813
query39	1479	1388	1416	1388
query40	230	136	122	122
query41	67	65	62	62
query42	130	117	111	111
query43	451	449	422	422
query44	1281	752	759	752
query45	200	193	185	185
query46	884	1002	649	649
query47	1698	1745	1701	1701
query48	397	418	325	325
query49	775	505	398	398
query50	677	693	422	422
query51	3864	3869	3921	3869
query52	119	112	110	110
query53	240	263	192	192
query54	312	291	285	285
query55	96	94	91	91
query56	331	334	341	334
query57	1147	1196	1097	1097
query58	299	276	271	271
query59	2284	2471	2310	2310
query60	370	361	335	335
query61	161	188	163	163
query62	788	711	653	653
query63	232	192	204	192
query64	4465	1201	959	959
query65	4060	4022	3935	3935
query66	1137	466	373	373
query67	15427	15263	14859	14859
query68	4609	990	634	634
query69	523	355	317	317
query70	1171	1006	982	982
query71	432	338	324	324
query72	6247	5138	5045	5045
query73	674	574	352	352
query74	8546	8833	8789	8789
query75	3022	3066	2507	2507
query76	3334	1127	729	729
query77	504	418	311	311
query78	9554	9755	8847	8847
query79	2079	822	587	587
query80	899	594	502	502
query81	538	271	244	244
query82	425	143	115	115
query83	280	267	251	251
query84	268	125	107	107
query85	912	501	464	464
query86	435	299	296	296
query87	4075	4136	3979	3979
query88	3370	2303	2306	2303
query89	394	333	304	304
query90	1943	228	221	221
query91	171	175	147	147
query92	87	77	67	67
query93	2505	1003	659	659
query94	815	453	348	348
query95	512	416	431	416
query96	514	552	288	288
query97	2643	2708	2630	2630
query98	249	224	212	212
query99	1297	1390	1245	1245
Total cold run time: 268424 ms
Total hot run time: 182183 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.18 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 87aaf1ecb0025b2b7dc1979a8916aa54b471ec3d, data reload: false

query1	0.06	0.06	0.05
query2	0.11	0.04	0.05
query3	0.26	0.09	0.08
query4	1.60	0.11	0.11
query5	0.29	0.26	0.25
query6	1.16	0.65	0.64
query7	0.03	0.03	0.03
query8	0.05	0.04	0.05
query9	0.57	0.51	0.50
query10	0.55	0.54	0.54
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.63	0.60	0.61
query14	1.01	0.99	0.99
query15	0.82	0.80	0.81
query16	0.41	0.40	0.42
query17	1.05	0.99	1.04
query18	0.27	0.23	0.22
query19	1.84	1.80	1.89
query20	0.01	0.02	0.01
query21	15.45	0.30	0.14
query22	4.69	0.06	0.05
query23	16.05	0.28	0.10
query24	1.33	0.82	0.20
query25	0.10	0.06	0.05
query26	0.15	0.14	0.14
query27	0.08	0.06	0.06
query28	4.36	1.22	1.02
query29	12.63	4.00	3.21
query30	0.29	0.16	0.11
query31	2.82	0.63	0.40
query32	3.23	0.56	0.46
query33	3.18	3.01	3.07
query34	16.74	5.19	4.55
query35	4.58	4.52	4.56
query36	0.64	0.50	0.50
query37	0.11	0.07	0.07
query38	0.07	0.04	0.03
query39	0.05	0.03	0.04
query40	0.18	0.15	0.13
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.03	0.03
Total cold run time: 97.92 s
Total hot run time: 27.18 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 8.33% (4/48) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.82% (18492/35012)
Line Coverage 38.35% (169355/441595)
Region Coverage 33.13% (131403/396638)
Branch Coverage 34.09% (56598/166033)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 8.33% (4/48) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.73% (24625/34329)
Line Coverage 58.24% (256948/441201)
Region Coverage 53.22% (213665/401449)
Branch Coverage 54.81% (91498/166930)

2 similar comments
@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 8.33% (4/48) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.73% (24625/34329)
Line Coverage 58.24% (256948/441201)
Region Coverage 53.22% (213665/401449)
Branch Coverage 54.81% (91498/166930)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 8.33% (4/48) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.73% (24625/34329)
Line Coverage 58.24% (256948/441201)
Region Coverage 53.22% (213665/401449)
Branch Coverage 54.81% (91498/166930)

morningman
morningman previously approved these changes Dec 2, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

PR approved by anyone and no changes requested.

Copy link
Contributor

@hubgeter hubgeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 2, 2025
@doris-robot
Copy link

TPC-DS: Total hot run time: 180849 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8f45088b0db0028aa614bd2ab62a9c0a02527202, data reload: false

query1	1064	404	390	390
query2	6568	1194	1202	1194
query3	6740	225	222	222
query4	25585	23301	22786	22786
query5	5021	638	474	474
query6	352	250	221	221
query7	4649	510	312	312
query8	312	263	244	244
query9	8739	2654	2679	2654
query10	537	349	350	349
query11	15487	14841	15053	14841
query12	196	114	112	112
query13	1667	557	429	429
query14	9666	5933	5997	5933
query15	208	198	185	185
query16	7598	681	510	510
query17	1195	749	621	621
query18	2040	429	336	336
query19	218	209	183	183
query20	130	132	132	132
query21	253	153	129	129
query22	4193	4469	4326	4326
query23	33681	32682	33199	32682
query24	9428	2510	2525	2510
query25	630	601	496	496
query26	1296	289	185	185
query27	2767	526	366	366
query28	4620	2212	2205	2205
query29	849	659	539	539
query30	316	272	231	231
query31	903	746	666	666
query32	91	84	76	76
query33	613	397	355	355
query34	876	919	572	572
query35	840	914	777	777
query36	919	954	833	833
query37	129	111	88	88
query38	3923	3947	3766	3766
query39	1509	1397	1407	1397
query40	226	129	117	117
query41	61	59	59	59
query42	124	107	110	107
query43	441	437	420	420
query44	1323	734	742	734
query45	197	197	182	182
query46	908	1017	650	650
query47	1718	1749	1654	1654
query48	412	429	339	339
query49	762	485	402	402
query50	667	692	413	413
query51	3820	3937	3865	3865
query52	115	111	99	99
query53	243	255	198	198
query54	309	297	285	285
query55	98	94	93	93
query56	316	338	321	321
query57	1131	1150	1093	1093
query58	285	273	266	266
query59	2265	2381	2301	2301
query60	359	343	330	330
query61	158	163	158	158
query62	765	724	663	663
query63	226	199	188	188
query64	4569	1309	992	992
query65	4070	3985	3967	3967
query66	1141	458	343	343
query67	15023	15098	14650	14650
query68	7667	975	620	620
query69	535	359	328	328
query70	1148	1059	1006	1006
query71	444	342	320	320
query72	5976	2828	5398	2828
query73	784	783	357	357
query74	8997	8935	8624	8624
query75	3034	3013	2525	2525
query76	3311	1126	751	751
query77	493	420	336	336
query78	9642	9696	8781	8781
query79	2253	907	590	590
query80	964	577	497	497
query81	543	271	231	231
query82	411	140	109	109
query83	262	275	253	253
query84	270	120	95	95
query85	901	488	446	446
query86	426	312	281	281
query87	4084	4031	3946	3946
query88	3725	2281	2287	2281
query89	387	328	299	299
query90	2017	217	217	217
query91	170	168	143	143
query92	83	71	64	64
query93	2645	1039	654	654
query94	792	445	351	351
query95	502	408	403	403
query96	559	566	285	285
query97	2570	2673	2564	2564
query98	258	219	207	207
query99	1309	1363	1241	1241
Total cold run time: 274702 ms
Total hot run time: 180849 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.42 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8f45088b0db0028aa614bd2ab62a9c0a02527202, data reload: false

query1	0.06	0.06	0.06
query2	0.10	0.05	0.05
query3	0.27	0.10	0.09
query4	1.62	0.12	0.12
query5	0.29	0.26	0.27
query6	1.21	0.68	0.64
query7	0.03	0.03	0.03
query8	0.07	0.06	0.04
query9	0.57	0.51	0.50
query10	0.56	0.58	0.57
query11	0.16	0.11	0.12
query12	0.16	0.13	0.12
query13	0.63	0.61	0.62
query14	1.02	1.00	1.00
query15	0.83	0.80	0.82
query16	0.40	0.42	0.42
query17	1.03	0.99	1.07
query18	0.26	0.21	0.22
query19	1.90	1.74	1.84
query20	0.02	0.02	0.02
query21	15.44	0.31	0.15
query22	4.73	0.06	0.05
query23	15.97	0.29	0.10
query24	0.97	0.26	0.54
query25	0.10	0.05	0.06
query26	0.15	0.13	0.14
query27	0.20	0.07	0.06
query28	3.96	1.27	1.03
query29	12.58	3.98	3.17
query30	0.32	0.17	0.14
query31	2.81	0.63	0.39
query32	3.24	0.56	0.46
query33	3.10	3.09	3.03
query34	16.64	5.35	4.58
query35	4.58	4.60	4.56
query36	0.67	0.51	0.50
query37	0.11	0.08	0.07
query38	0.08	0.05	0.04
query39	0.05	0.03	0.04
query40	0.18	0.14	0.15
query41	0.09	0.04	0.03
query42	0.05	0.04	0.03
query43	0.05	0.04	0.04
Total cold run time: 97.26 s
Total hot run time: 27.42 s

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34206 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8f45088b0db0028aa614bd2ab62a9c0a02527202, data reload: false

------ Round 1 ----------------------------------
q1	17625	5079	4912	4912
q2	2562	311	205	205
q3	10311	1361	790	790
q4	10235	801	316	316
q5	7804	2476	2177	2177
q6	185	167	137	137
q7	990	812	646	646
q8	9406	1450	1117	1117
q9	7157	5359	5441	5359
q10	6850	2181	1755	1755
q11	527	312	278	278
q12	330	367	221	221
q13	17808	3651	3015	3015
q14	246	237	213	213
q15	592	520	505	505
q16	873	857	802	802
q17	680	829	466	466
q18	7677	7152	7033	7033
q19	1089	943	608	608
q20	369	347	228	228
q21	4006	3099	2466	2466
q22	1049	1035	957	957
Total cold run time: 108371 ms
Total hot run time: 34206 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4926	4908	4891	4891
q2	331	432	315	315
q3	2164	2689	2285	2285
q4	1308	1726	1264	1264
q5	4212	4513	4542	4513
q6	216	170	130	130
q7	2000	1986	1771	1771
q8	2810	2629	2510	2510
q9	7532	7486	7584	7486
q10	3162	3228	2797	2797
q11	599	522	505	505
q12	694	752	632	632
q13	3577	3899	3370	3370
q14	290	313	282	282
q15	570	521	532	521
q16	908	927	880	880
q17	1264	1475	1554	1475
q18	7884	7564	7684	7564
q19	847	894	862	862
q20	1997	2056	1929	1929
q21	5025	4524	4197	4197
q22	1090	1032	989	989
Total cold run time: 53406 ms
Total hot run time: 51168 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 182177 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8f45088b0db0028aa614bd2ab62a9c0a02527202, data reload: false

query1	1016	418	394	394
query2	6599	1204	1175	1175
query3	6737	224	226	224
query4	25178	23405	22914	22914
query5	5093	643	486	486
query6	349	242	228	228
query7	4642	533	309	309
query8	301	256	242	242
query9	8718	2648	2641	2641
query10	543	358	331	331
query11	15514	15219	14691	14691
query12	187	116	114	114
query13	1670	571	428	428
query14	9564	6124	6125	6124
query15	214	193	183	183
query16	7610	682	523	523
query17	1182	754	644	644
query18	2060	442	347	347
query19	222	215	188	188
query20	136	125	120	120
query21	225	136	116	116
query22	3968	3876	3898	3876
query23	32829	31962	31969	31962
query24	8491	2496	2445	2445
query25	625	513	468	468
query26	1245	284	165	165
query27	2746	505	350	350
query28	4369	2156	2153	2153
query29	802	624	489	489
query30	328	239	218	218
query31	807	707	626	626
query32	84	74	71	71
query33	594	396	337	337
query34	852	879	547	547
query35	791	848	756	756
query36	904	928	840	840
query37	128	112	83	83
query38	3907	3906	3854	3854
query39	1446	1404	1412	1404
query40	231	136	118	118
query41	67	76	62	62
query42	124	125	110	110
query43	438	449	414	414
query44	1408	745	745	745
query45	199	196	187	187
query46	905	1004	651	651
query47	1663	1678	1660	1660
query48	403	423	325	325
query49	784	492	407	407
query50	696	698	423	423
query51	3982	3969	3878	3878
query52	110	116	111	111
query53	252	263	194	194
query54	312	305	286	286
query55	97	93	90	90
query56	342	328	324	324
query57	1140	1176	1072	1072
query58	288	286	280	280
query59	2220	2345	2274	2274
query60	354	349	345	345
query61	162	157	155	155
query62	800	711	652	652
query63	232	199	195	195
query64	4552	1214	995	995
query65	4068	3980	4033	3980
query66	1137	472	356	356
query67	15071	15003	14710	14710
query68	4733	1020	643	643
query69	536	354	323	323
query70	1103	1014	1013	1013
query71	428	351	319	319
query72	6195	4896	4984	4896
query73	711	641	344	344
query74	8787	8789	8639	8639
query75	3073	3009	2546	2546
query76	3324	1165	764	764
query77	508	417	319	319
query78	9376	9667	8900	8900
query79	1852	874	615	615
query80	717	607	531	531
query81	520	273	238	238
query82	193	142	112	112
query83	267	270	253	253
query84	255	129	101	101
query85	879	493	449	449
query86	381	280	279	279
query87	3956	4054	3997	3997
query88	3073	2339	2346	2339
query89	397	335	294	294
query90	1994	232	227	227
query91	170	175	138	138
query92	88	73	68	68
query93	2132	1027	655	655
query94	725	453	342	342
query95	516	422	408	408
query96	555	554	288	288
query97	2582	2675	2573	2573
query98	251	226	221	221
query99	1291	1377	1278	1278
Total cold run time: 266281 ms
Total hot run time: 182177 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.31 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8f45088b0db0028aa614bd2ab62a9c0a02527202, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.09	0.09
query4	1.60	0.12	0.11
query5	0.29	0.24	0.24
query6	1.17	0.66	0.63
query7	0.03	0.02	0.02
query8	0.06	0.04	0.04
query9	0.58	0.51	0.51
query10	0.56	0.56	0.55
query11	0.16	0.11	0.11
query12	0.14	0.12	0.11
query13	0.62	0.60	0.61
query14	1.01	1.00	0.98
query15	0.82	0.80	0.80
query16	0.42	0.42	0.39
query17	1.00	1.06	1.00
query18	0.24	0.22	0.22
query19	1.95	1.88	1.85
query20	0.02	0.01	0.01
query21	15.44	0.30	0.14
query22	4.70	0.05	0.05
query23	16.08	0.28	0.09
query24	0.93	0.70	0.19
query25	0.06	0.06	0.06
query26	0.15	0.14	0.15
query27	0.06	0.05	0.06
query28	3.81	1.23	1.02
query29	12.63	3.94	3.17
query30	0.27	0.14	0.13
query31	2.82	0.63	0.40
query32	3.24	0.55	0.46
query33	2.96	3.11	3.17
query34	16.89	5.15	4.61
query35	4.53	4.49	4.57
query36	0.67	0.50	0.49
query37	0.11	0.07	0.06
query38	0.07	0.04	0.04
query39	0.05	0.03	0.03
query40	0.17	0.15	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.04
Total cold run time: 96.89 s
Total hot run time: 27.31 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 7.84% (4/51) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.51% (18734/35010)
Line Coverage 39.10% (172687/441701)
Region Coverage 33.72% (133750/396686)
Branch Coverage 34.65% (57550/166080)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 7.84% (4/51) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.24% (24798/34326)
Line Coverage 58.86% (259762/441306)
Region Coverage 53.76% (215851/401496)
Branch Coverage 55.25% (92255/166977)

Copy link
Contributor

@hubgeter hubgeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

PR approved by at least one committer and no changes requested.

@zhangstar333 zhangstar333 merged commit f0e87c5 into apache:master Dec 2, 2025
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 2, 2025
### What problem does this PR solve?
Problem Summary:
before not deal with float16 type, so it's mapping to string type, and
the result is invaild eg:
```
mysql> select * from HDFS("uri" = "hdfs://127.0.0.1:8020/user/doris/tvf_data/test_hdfs_parquet/group0/float16_nonzeros_and_nans.parquet",                         "hadoop.username" = "doris",                         "format" = "parquet");
+------+
| x    |
+------+
| NULL |
|  <   |
|  �    |
|  ~   |
|      |
|  �    |
|  �    |
|  @   |
+------+
```

but it's could mapping to float type, eg:
```
mysql>  select x from file(     "fs.local.support" = "true",     "file_path" = "float16_nonzeros_and_nans.parquet",    "format" = "parquet",'shared_storage'='true' );
+------+
| x    |
+------+
| NULL |
|    1 |
|   -2 |
|  NaN |
|    0 |
|   -1 |
|   -0 |
|    2 |
+------+
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/3.1.x-conflict dev/4.0.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants