[issue-547] Knative should not be required to install and run the SonataFlow Operator to deploy workflows

Author: jianrongzhang89

Makefile

@@ -123,8 +123,7 @@ test: manifests generate envtest test-api ## Run tests.
 	@$(MAKE) vet
 	@$(MAKE) fmt
 	@echo "🔍 Running controller tests..."
-	@KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" \
-	go test $(shell go list ./... | grep -v /test/) -coverprofile cover.out > /dev/null 2>&1
+	KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" go test $(shell go list ./... | grep -v /test/) -coverprofile cover.out
 	@echo "✅  Tests completed successfully. Coverage report generated: cover.out."
 
 .PHONY: test-api

internal/controller/profiles/common/object_creators.go

@@ -26,7 +26,6 @@ import (
 
 	"github.com/apache/incubator-kie-kogito-serverless-operator/internal/controller/profiles"
 
-	"github.com/apache/incubator-kie-kogito-serverless-operator/internal/controller/workflowdef"
 	servingv1 "knative.dev/serving/pkg/apis/serving/v1"
 
 	cncfmodel "github.com/serverlessworkflow/sdk-go/v2/model"
@@ -46,7 +45,6 @@ import (
 
 	operatorapi "github.com/apache/incubator-kie-kogito-serverless-operator/api/v1alpha08"
 	"github.com/apache/incubator-kie-kogito-serverless-operator/internal/controller/knative"
-	"github.com/apache/incubator-kie-kogito-serverless-operator/internal/controller/platform/services"
 	"github.com/apache/incubator-kie-kogito-serverless-operator/internal/controller/profiles/common/constants"
 	"github.com/apache/incubator-kie-kogito-serverless-operator/internal/controller/profiles/common/persistence"
 	"github.com/apache/incubator-kie-kogito-serverless-operator/internal/controller/profiles/common/properties"
@@ -281,14 +279,7 @@ func SinkBindingCreator(workflow *operatorapi.SonataFlow, plf *operatorapi.Sonat
 	if err != nil {
 		return nil, err
 	}
-	dataIndexEnabled := services.IsDataIndexEnabled(plf)
-	jobServiceEnabled := services.IsJobServiceEnabled(plf)
-
-	// skip if no produced event is found and there is no DataIndex/JobService enabled
 	if sink == nil {
-		if dataIndexEnabled || jobServiceEnabled || workflowdef.ContainsEventKind(workflow, cncfmodel.EventKindProduced) {
-			return nil, fmt.Errorf("a sink in the SonataFlow %s or broker in the SonataFlowPlatform %s should be configured when DataIndex or JobService is enabled", workflow.Name, plf.Name)
-		}
 		return nil, nil /*nothing to do*/
 	}
 
@@ -385,11 +376,9 @@ func TriggersCreator(workflow *operatorapi.SonataFlow, plf *operatorapi.SonataFl
 		if err != nil {
 			return nil, err
 		}
-		if brokerRef == nil {
-			return nil, fmt.Errorf("no broker configured for eventType %s in SonataFlow %s", event.Type, workflow.Name)
-		}
-		if !knative.IsKnativeBroker(brokerRef) {
-			return nil, fmt.Errorf("no valid broker configured for eventType %s in SonataFlow %s", event.Type, workflow.Name)
+		if brokerRef == nil || !knative.IsKnativeBroker(brokerRef) {
+			// No broker configured for the eventType. Skip and will not create trigger for it.
+			continue
 		}
 		if err := knative.ValidateBroker(brokerRef.Name, brokerRef.Namespace); err != nil {
 			return nil, err

internal/controller/profiles/common/object_creators_test.go

@@ -245,8 +245,7 @@ func TestEnsureWorkflowSinkBindingWithoutBrokerAreNotCreated(t *testing.T) {
 	plf := test.GetBasePlatformWithBroker()
 	plf.Spec.Eventing = nil // No broker configured in the platform, but data index and jobs service are enabled
 	sinkBinding, err := SinkBindingCreator(workflow, plf)
-	assert.Error(t, err)
-	assert.Contains(t, err.Error(), "a sink in the SonataFlow vet or broker in the SonataFlowPlatform sonataflow-platform should be configured when DataIndex or JobService is enabled")
+	assert.NoError(t, err)
 	assert.Nil(t, sinkBinding)
 }
 
@@ -371,8 +370,7 @@ func TestEnsureWorkflowTriggersWithoutBrokerAreNotCreated(t *testing.T) {
 	plf := test.GetBasePlatform()
 
 	triggers, err := TriggersCreator(workflow, plf)
-	assert.Error(t, err)
-	assert.Contains(t, err.Error(), "no broker configured for eventType events.vet.appointments in SonataFlow vet")
+	assert.NoError(t, err)
 	assert.Nil(t, triggers)
 }
 

internal/controller/profiles/preview/deployment_handler.go

@@ -19,7 +19,6 @@ package preview
 
 import (
 	"context"
-	"fmt"
 
 	"github.com/apache/incubator-kie-kogito-serverless-operator/internal/controller/knative"
 	v1 "k8s.io/api/core/v1"
@@ -30,7 +29,6 @@ import (
 	"github.com/apache/incubator-kie-kogito-serverless-operator/api"
 	operatorapi "github.com/apache/incubator-kie-kogito-serverless-operator/api/v1alpha08"
 	"github.com/apache/incubator-kie-kogito-serverless-operator/internal/controller/platform"
-	"github.com/apache/incubator-kie-kogito-serverless-operator/internal/controller/platform/services"
 	"github.com/apache/incubator-kie-kogito-serverless-operator/internal/controller/profiles/common"
 	"github.com/apache/incubator-kie-kogito-serverless-operator/internal/controller/profiles/common/constants"
 	"github.com/apache/incubator-kie-kogito-serverless-operator/utils"
@@ -58,11 +56,6 @@ func (d *DeploymentReconciler) reconcileWithImage(ctx context.Context, workflow
 		return reconcile.Result{Requeue: false}, nil, err
 	}
 
-	// Checks if the workflow has sink configured.
-	if requires, err := d.ensureKnativeSinkConfigured(workflow); requires || err != nil {
-		return reconcile.Result{Requeue: false}, nil, err
-	}
-
 	// Ensure objects
 	result, objs, err := d.ensureObjects(ctx, workflow, image)
 	if err != nil || result.Requeue {
@@ -99,32 +92,6 @@ func (d *DeploymentReconciler) ensureKnativeServingRequired(workflow *operatorap
 	return false, nil
 }
 
-// if Knative Eventing is available, the workflow should have a sink configured, or the platform should have a broker defined
-func (d *DeploymentReconciler) ensureKnativeSinkConfigured(workflow *operatorapi.SonataFlow) (bool, error) {
-	avail, err := knative.GetKnativeAvailability(d.Cfg)
-	if err != nil {
-		return true, err
-	}
-	if !avail.Eventing {
-		return false, nil
-	}
-	platform, err := platform.GetActivePlatform(context.TODO(), d.C, workflow.Namespace)
-	if err != nil {
-		return true, err
-	}
-	sink, err := knative.GetWorkflowSink(workflow, platform)
-	if err != nil {
-		return true, err
-	}
-	if sink == nil && (services.IsDataIndexEnabled(platform) || services.IsJobServiceEnabled(platform)) {
-		d.Recorder.Eventf(workflow, v1.EventTypeWarning,
-			"KnativeSinkNotConfigured",
-			"Failed to deploy workflow. No sink configured in the workflow or the platform when Job Service or Data Index Service is enabled.")
-		return true, fmt.Errorf("no sink configured in the workflow or the platform when Job Service or Data Index Service is enabled")
-	}
-	return false, nil
-}
-
 func (d *DeploymentReconciler) ensureObjects(ctx context.Context, workflow *operatorapi.SonataFlow, image string) (reconcile.Result, []client.Object, error) {
 	pl, _ := platform.GetActivePlatform(ctx, d.C, workflow.Namespace)
 	userPropsCM, _, err := d.ensurers.userPropsConfigMap.Ensure(ctx, workflow)