fix: Connections leaks in resource manager

xuzifu666 · xuzifu666 · commit f3ffd8593a16 · 2025-12-02T14:47:11.000+08:00
diff --git a/pkg/datasource/sql/xa_resource_manager.go b/pkg/datasource/sql/xa_resource_manager.go
@@ -166,6 +166,7 @@ func (xaManager *XAResourceManager) BranchCommit(ctx context.Context, branchReso
 	if err != nil {
 		return branch.BranchStatusPhasetwoRollbackFailedUnretryable, err
 	}
+	defer connectionProxyXA.Close()
 
 	if err := connectionProxyXA.XaCommit(ctx, xaID); err != nil {
 		log.Errorf("commit xa, resourceId: %s, err %v", branchResource.ResourceId, err)
@@ -183,6 +184,7 @@ func (xaManager *XAResourceManager) BranchRollback(ctx context.Context, branchRe
 	if err != nil {
 		return branch.BranchStatusPhasetwoRollbackFailedUnretryable, err
 	}
+	defer connectionProxyXA.Close()
 
 	if err = connectionProxyXA.XaRollbackByBranchId(ctx, xaID); err != nil {
 		log.Errorf("rollback xa, resourceId: %s, err %v", branchResource.ResourceId, err)

Original file line number	Diff line number	Diff line change
`@@ -166,6 +166,7 @@ func (xaManager *XAResourceManager) BranchCommit(ctx context.Context, branchReso`
`166`	`166`	`if err != nil {`
`167`	`167`	`return branch.BranchStatusPhasetwoRollbackFailedUnretryable, err`
`168`	`168`	`}`
	`169`	`+ defer connectionProxyXA.Close()`
`169`	`170`
`170`	`171`	`if err := connectionProxyXA.XaCommit(ctx, xaID); err != nil {`
`171`	`172`	`log.Errorf("commit xa, resourceId: %s, err %v", branchResource.ResourceId, err)`
`@@ -183,6 +184,7 @@ func (xaManager *XAResourceManager) BranchRollback(ctx context.Context, branchRe`
`183`	`184`	`if err != nil {`
`184`	`185`	`return branch.BranchStatusPhasetwoRollbackFailedUnretryable, err`
`185`	`186`	`}`
	`187`	`+ defer connectionProxyXA.Close()`
`186`	`188`
`187`	`189`	`if err = connectionProxyXA.XaRollbackByBranchId(ctx, xaID); err != nil {`
`188`	`190`	`log.Errorf("rollback xa, resourceId: %s, err %v", branchResource.ResourceId, err)`