bugfix: fix connection leaks and potential nil pointer panic(#991) #997
+12
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
pkg/datasource/sql/datasource/base/meta_cache.goby addingdefer conn.Close()pkg/datasource/sql/db.goby addingdefer conn.Close()pkg/datasource/sql/async_worker.goto prevent nil pointer panic whendb.Conn()failsWhich issue(s) this PR fixes:
Fixes #991
Special notes for your reviewer:
Does this PR introduce a user-facing change?: