Skip to content

Commit 0cc80b2

Browse files
sudohainguyenpan3793
authored andcommitted
[KYUUBI #6298][HELM] Make ServiceMonitor use selector labels
# 🔍 Description ## Issue References 🔗 This pull request fixes #6298 ## Describe Your Solution 🔧 Change matchlabels field to use template `selectorLabels` ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ ServiceMonitor is not able to match kyuubi service #### Related Unit Tests Ran `helm template` and produced yaml files as expected --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6301 from sudohainguyen/helmchart. Closes #6298 cdc6698 [Harry] Include template consistently bd82fb4 [Harry] [KYUUBI #6298][HELM] Make ServiceMonitor use selector labels to discover metric service Authored-by: Harry <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 968fa09) Signed-off-by: Cheng Pan <[email protected]>
1 parent 3930d14 commit 0cc80b2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

charts/kyuubi/templates/kyuubi-servicemonitor.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ metadata:
2525
spec:
2626
selector:
2727
matchLabels:
28-
app: {{ .Release.Name }}
28+
{{- include "kyuubi.selectorLabels" . | nindent 6 }}
2929
endpoints:
3030
{{- toYaml .Values.serviceMonitor.endpoints | nindent 4 }}
3131
{{- end }}

0 commit comments

Comments
 (0)