Skip to content

Commit e0a80f2

Browse files
committed
[KYUUBI #6762] [BUILD] cleanup dockerfile warnings
# 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 - fix the dockerfile warning reported by `GitHub Actions / Kyuubi Server On Kubernetes Integration Test` : - Legacy key/value format with whitespace separator should not be used LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/ - The 'as' keyword should match the case of the 'from' keyword FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/ ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6762 from bowenliang123/docker-warning. Closes #6762 d9d7b74 [Bowen Liang] cleanup dockerfile warning Authored-by: Bowen Liang <[email protected]> Signed-off-by: Bowen Liang <[email protected]>
1 parent 7cb6af1 commit e0a80f2

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

build/Dockerfile.CI

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
# see: https://github.com/moby/moby/issues/38379
3434
ARG BASE_IMAGE=eclipse-temurin:8-jdk-focal
3535

36-
FROM eclipse-temurin:8-jdk-focal as builder
36+
FROM eclipse-temurin:8-jdk-focal AS builder
3737

3838
ARG MVN_ARG
3939

@@ -43,7 +43,7 @@ ARG MVN_ARG
4343
# an environment variable `CI` in runners, and we detect this variable to run some
4444
# specific actions, e.g. run `mvn` in batch mode to suppress noisy logs.
4545
ARG CI
46-
ENV CI ${CI}
46+
ENV CI=${CI}
4747

4848
ADD . /workspace/kyuubi
4949
WORKDIR /workspace/kyuubi
@@ -64,10 +64,10 @@ ARG kyuubi_uid=10009
6464

6565
USER root
6666

67-
ENV KYUUBI_HOME /opt/kyuubi
68-
ENV KYUUBI_LOG_DIR ${KYUUBI_HOME}/logs
69-
ENV KYUUBI_PID_DIR ${KYUUBI_HOME}/pid
70-
ENV KYUUBI_WORK_DIR_ROOT ${KYUUBI_HOME}/work
67+
ENV KYUUBI_HOME=/opt/kyuubi
68+
ENV KYUUBI_LOG_DIR=${KYUUBI_HOME}/logs
69+
ENV KYUUBI_PID_DIR=${KYUUBI_HOME}/pid
70+
ENV KYUUBI_WORK_DIR_ROOT=${KYUUBI_HOME}/work
7171

7272
COPY --from=builder /opt/kyuubi ${KYUUBI_HOME}
7373

docker/Dockerfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ FROM builder_${spark_provided}
4040
ARG kyuubi_uid=10009
4141
USER root
4242

43-
ENV KYUUBI_HOME /opt/kyuubi
44-
ENV KYUUBI_LOG_DIR ${KYUUBI_HOME}/logs
45-
ENV KYUUBI_PID_DIR ${KYUUBI_HOME}/pid
46-
ENV KYUUBI_WORK_DIR_ROOT ${KYUUBI_HOME}/work
43+
ENV KYUUBI_HOME=/opt/kyuubi
44+
ENV KYUUBI_LOG_DIR=${KYUUBI_HOME}/logs
45+
ENV KYUUBI_PID_DIR=${KYUUBI_HOME}/pid
46+
ENV KYUUBI_WORK_DIR_ROOT=${KYUUBI_HOME}/work
4747

4848
RUN set -ex && \
4949
sed -i 's/http:\/\/deb.\(.*\)/https:\/\/deb.\1/g' /etc/apt/sources.list && \

0 commit comments

Comments
 (0)