fix

Author: JingsongLi

paimon-common/src/main/java/org/apache/paimon/predicate/Like.java

@@ -65,6 +65,8 @@ private Filter<BinaryString> createFunc(DataType type, Object patternLiteral) {
             Object literal = optimized.get().getValue();
             return field -> func.test(type, field, literal);
         }
+        // TODO optimize for chain checkers when there is no '_'
+        // TODO for example: "abc%def%","%abc%def","%abc%def%","abc%def"
         String regex = sqlToRegexLike(patternLiteral.toString(), null);
         Pattern pattern = Pattern.compile(regex);
         return input -> pattern.matcher(input.toString()).matches();

paimon-common/src/test/java/org/apache/paimon/predicate/PredicateTest.java

@@ -22,6 +22,7 @@
 import org.apache.paimon.data.GenericRow;
 import org.apache.paimon.format.SimpleColStats;
 import org.apache.paimon.types.CharType;
+import org.apache.paimon.types.DataTypes;
 import org.apache.paimon.types.IntType;
 import org.apache.paimon.types.RowType;
 import org.apache.paimon.types.VarCharType;
@@ -31,6 +32,7 @@
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
+import java.util.concurrent.ThreadLocalRandom;
 
 import static org.apache.paimon.data.BinaryString.fromString;
 import static org.apache.paimon.predicate.SimpleColStatsTestUtils.test;
@@ -522,25 +524,27 @@ public void testLargeNotInNull() {
     }
 
     @Test
-    public void testLike() {
+    public void executeLike() {
         // test eval
-        assertThat(testLike("abc", "a.c")).isEqualTo(false);
-        assertThat(testLike("a.c", "a.c")).isEqualTo(true);
-        assertThat(testLike("abcd", "a.*d")).isEqualTo(false);
-        assertThat(testLike("abcde", "%c.e")).isEqualTo(false);
-        assertThat(testLike("a-c", "a\\_c")).isEqualTo(false);
-        assertThat(testLike("a_c", "a\\_c")).isEqualTo(true);
-        assertThat(testLike("startX", "start%")).isEqualTo(true);
-        assertThat(testLike("not_startX", "start%")).isEqualTo(false);
-        assertThat(testLike("xxmiddleyy", "%middle%")).isEqualTo(true);
-        assertThat(testLike("xxmidxdleyy", "%middle%")).isEqualTo(false);
-        assertThat(testLike("xxend", "%end")).isEqualTo(true);
-        assertThat(testLike("xxendyy", "%end")).isEqualTo(false);
-        assertThat(testLike("equal", "equal")).isEqualTo(true);
-        assertThat(testLike("equalxx", "equal")).isEqualTo(false);
-        assertThat(testLike("startxx", "st_rt%")).isEqualTo(true);
-        assertThat(testLike("stbrtxx", "st_rt%")).isEqualTo(true);
-        assertThat(testLike("xxstbrtxx", "st_rt%")).isEqualTo(false);
+        assertThat(executeLike("abc", "a.c")).isEqualTo(false);
+        assertThat(executeLike("a.c", "a.c")).isEqualTo(true);
+        assertThat(executeLike("abcd", "a.*d")).isEqualTo(false);
+        assertThat(executeLike("abcde", "%c.e")).isEqualTo(false);
+        assertThat(executeLike("a-c", "a\\_c")).isEqualTo(false);
+        assertThat(executeLike("a_c", "a\\_c")).isEqualTo(true);
+        assertThat(executeLike("startX", "start%")).isEqualTo(true);
+        assertThat(executeLike("not_startX", "start%")).isEqualTo(false);
+        assertThat(executeLike("xxmiddleyy", "%middle%")).isEqualTo(true);
+        assertThat(executeLike("xxmidxdleyy", "%middle%")).isEqualTo(false);
+        assertThat(executeLike("xxend", "%end")).isEqualTo(true);
+        assertThat(executeLike("xxendyy", "%end")).isEqualTo(false);
+        assertThat(executeLike("equal", "equal")).isEqualTo(true);
+        assertThat(executeLike("equalxx", "equal")).isEqualTo(false);
+        assertThat(executeLike("startxx", "st_rt%")).isEqualTo(true);
+        assertThat(executeLike("stbrtxx", "st_rt%")).isEqualTo(true);
+        assertThat(executeLike("xxstbrtxx", "st_rt%")).isEqualTo(false);
+        assertThat(executeLike("abchahadefxx", "abc%def%")).isEqualTo(true);
+        assertThat(executeLike("abchahadafxx", "abc%def%")).isEqualTo(false);
 
         // test instance
         assertThat(getLikeFunc("equal")).isEqualTo(Equal.INSTANCE);
@@ -550,10 +554,15 @@ public void testLike() {
         assertThat(getLikeFunc("a_c")).isEqualTo(Like.INSTANCE);
     }
 
-    private boolean testLike(String s, String pattern) {
-        PredicateBuilder builder = new PredicateBuilder(RowType.of(new VarCharType()));
-        Predicate predicate = builder.like(0, fromString(pattern));
-        return predicate.test(GenericRow.of(fromString(s)));
+    private boolean executeLike(String s, String pattern) {
+        ThreadLocalRandom rnd = ThreadLocalRandom.current();
+        if (rnd.nextBoolean()) {
+            PredicateBuilder builder = new PredicateBuilder(RowType.of(new VarCharType()));
+            Predicate predicate = builder.like(0, fromString(pattern));
+            return predicate.test(GenericRow.of(fromString(s)));
+        } else {
+            return Like.INSTANCE.test(DataTypes.STRING(), fromString(s), fromString(pattern));
+        }
     }
 
     private LeafFunction getLikeFunc(String pattern) {