-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][client] Skip processing messages in the listener when the consumer has been closed #25006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhotari
merged 2 commits into
apache:master
from
lhotari:lh-fix-client-race-condition-in-closing
Nov 24, 2025
Merged
[fix][client] Skip processing messages in the listener when the consumer has been closed #25006
lhotari
merged 2 commits into
apache:master
from
lhotari:lh-fix-client-race-condition-in-closing
Nov 24, 2025
+199
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #25006 +/- ##
============================================
+ Coverage 74.27% 74.29% +0.01%
- Complexity 33563 33680 +117
============================================
Files 1920 1920
Lines 150279 150293 +14
Branches 17448 17454 +6
============================================
+ Hits 111618 111655 +37
+ Misses 29768 29719 -49
- Partials 8893 8919 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dao-jun
approved these changes
Nov 24, 2025
Member
dao-jun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 1, 2025
…mer has been closed (apache#25006) (cherry picked from commit 43f75df) (cherry picked from commit 325d17c)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 2, 2025
…mer has been closed (apache#25006) (cherry picked from commit 43f75df) (cherry picked from commit 4537fc8)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 2, 2025
…mer has been closed (apache#25006) (cherry picked from commit 43f75df) (cherry picked from commit 325d17c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 2, 2025
…mer has been closed (apache#25006) (cherry picked from commit 43f75df) (cherry picked from commit 4537fc8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/client
cherry-picked/branch-3.0
cherry-picked/branch-4.0
cherry-picked/branch-4.1
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.16
release/4.0.9
release/4.1.3
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23193
Motivation
There's currently a NPE that happens when a multi-topic consumer has been closed and there are pending messages buffered in the message listener executor's queue.
Modifications
unAckedMessageTrackerfinal and don't set it to null while closing a multi-topic consumerDocumentation
docdoc-requireddoc-not-neededdoc-complete