Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Nov 21, 2025

Motivation

Cleanup code in MultiTopicsConsumerImpl.

Modifications

  • cleanup pause/resume logic for internal consumers
  • cleanup and replace the putIfAbsent logic

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.2.0 milestone Nov 21, 2025
@lhotari lhotari self-assigned this Nov 21, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 21, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 62.96296% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.33%. Comparing base (807dcaf) to head (ae28a15).

Files with missing lines Patch % Lines
...he/pulsar/client/impl/MultiTopicsConsumerImpl.java 62.96% 8 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #25009      +/-   ##
============================================
+ Coverage     74.27%   74.33%   +0.06%     
- Complexity    33563    34078     +515     
============================================
  Files          1920     1920              
  Lines        150279   150263      -16     
  Branches      17448    17447       -1     
============================================
+ Hits         111618   111699      +81     
+ Misses        29768    29656     -112     
- Partials       8893     8908      +15     
Flag Coverage Δ
inttests 26.39% <33.33%> (?)
systests 22.87% <14.81%> (+0.02%) ⬆️
unittests 73.86% <62.96%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...he/pulsar/client/impl/MultiTopicsConsumerImpl.java 76.36% <62.96%> (-0.65%) ⬇️

... and 99 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/client doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants