Skip to content

[fix][client] Fix thread-safety of AutoProduceBytesSchema #25014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2025
+9 −7
Merged

[fix][client] Fix thread-safety of AutoProduceBytesSchema #25014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AutoProduceBytesSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,12 @@
public class AutoProduceBytesSchema<T> implements Schema<byte[]> {

@Setter
private boolean requireSchemaValidation = true;
private Schema<T> schema;
private boolean userProvidedSchema;
private volatile boolean requireSchemaValidation = true;
private volatile Schema<T> schema;
private final boolean userProvidedSchema;

public AutoProduceBytesSchema() {
this.userProvidedSchema = false;
}

public AutoProduceBytesSchema(Schema<T> schema) {
Expand Down Expand Up @@ -81,11 +82,12 @@ public byte[] encode(byte[] message) {

if (requireSchemaValidation) {
// verify if the message can be decoded by the underlying schema
if (schema instanceof KeyValueSchema
&& ((KeyValueSchema) schema).getKeyValueEncodingType().equals(KeyValueEncodingType.SEPARATED)) {
((KeyValueSchema) schema).getValueSchema().validate(message);
Schema<T> localSchema = schema;
if (localSchema instanceof KeyValueSchema && ((KeyValueSchema) localSchema).getKeyValueEncodingType()
.equals(KeyValueEncodingType.SEPARATED)) {
((KeyValueSchema) localSchema).getValueSchema().validate(message);
} else {
schema.validate(message);
localSchema.validate(message);
}
}

Expand Down
Loading