Skip to content

Commit 1a3c922

Browse files
RongtongJinRongtongJin
andauthored
Defer the shutdown behavior of popConsumerService to prevent JVM crash (#9889)
Change-Id: Iaa23996d94f81ed3250b8d528338e8502a35cada Co-authored-by: RongtongJin <[email protected]>
1 parent 9f58198 commit 1a3c922

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1442,10 +1442,6 @@ protected void shutdownBasicService() {
14421442
this.pullRequestHoldService.shutdown();
14431443
}
14441444

1445-
if (this.popConsumerService != null) {
1446-
this.popConsumerService.shutdown();
1447-
}
1448-
14491445
if (this.popMessageProcessor.getPopLongPollingService() != null) {
14501446
this.popMessageProcessor.getPopLongPollingService().shutdown();
14511447
}
@@ -1641,6 +1637,10 @@ protected void shutdownBasicService() {
16411637
}
16421638
}
16431639

1640+
if (this.popConsumerService != null) {
1641+
this.popConsumerService.shutdown();
1642+
}
1643+
16441644
if (this.messageStore != null) {
16451645
this.messageStore.shutdown();
16461646
}

0 commit comments

Comments
 (0)