Skip to content

[ISSUE #9883] Remove unnecessary MessageFormat.format #9884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+3 −4
Open

[ISSUE #9883] Remove unnecessary MessageFormat.format #9884

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16d000c
[ISSUE #9883] Remove unnecessary MessageFormat.format
yx9o Nov 29, 2025
254556b
Update import
yx9o Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@
import org.apache.rocketmq.tools.command.CommandUtil;

import java.io.UnsupportedEncodingException;
import java.text.MessageFormat;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
Expand Down Expand Up @@ -905,19 +904,19 @@ public void run() {
resetOffsetByTimestampOld(addr, topicRouteMap.get(bd.getBrokerName()), group, topic, timestamp, true);
successList.add(addr);
} catch (Exception e2) {
logger.error(MessageFormat.format("resetOffsetByTimestampOld error. addr={0}, topic={1}, group={2},timestamp={3}", addr, topic, group, timestamp), e);
logger.error("resetOffsetByTimestampOld error. addr={}, topic={}, group={}, timestamp={}", addr, topic, group, timestamp, e);
failureList.add(addr);
}
} else if (ResponseCode.SYSTEM_ERROR == e.getResponseCode()) {
// CODE: 1 DESC: THe consumer group <GID_newggghh> not exist, never online
successList.add(addr);
} else {
failureList.add(addr);
logger.error(MessageFormat.format("resetOffsetNewConcurrent error. addr={0}, topic={1}, group={2},timestamp={3}", addr, topic, group, timestamp), e);
logger.error("resetOffsetNewConcurrent error. addr={}, topic={}, group={}, timestamp={}", addr, topic, group, timestamp, e);
}
} catch (Exception e) {
failureList.add(addr);
logger.error(MessageFormat.format("resetOffsetNewConcurrent error. addr={0}, topic={1}, group={2},timestamp={3}", addr, topic, group, timestamp), e);
logger.error("resetOffsetNewConcurrent error. addr={}, topic={}, group={}, timestamp={}", addr, topic, group, timestamp, e);
} finally {
latch.countDown();
}
Expand Down
Loading