Fix

Author: jiayuasu

docker/test-notebooks.sh

@@ -170,24 +170,42 @@ with open(file_path, 'w') as f:
     f.write(content)
 PYTHON_CLEANUP
 
-    # Run the Python file with pyspark
-    echo "  Running Python script..."
-    # Change to workspace directory so relative paths work correctly
+    # Validate Python syntax first
+    echo "  Validating Python syntax..."
+    if ! python3 -m py_compile "$PYTHON_FILE" >/dev/null 2>/dev/null; then
+        echo "  ✗ Python syntax validation failed"
+        FAILED_TESTS=$((FAILED_TESTS + 1))
+        echo ""
+        continue
+    fi
+
+    # Run the full Python script with timeout (600 seconds = 10 minutes)
+    echo "  Running Python script (600 second timeout)..."
     cd "$EXAMPLES_DIR/.."
-    # Use timeout to prevent hanging tests (10 minutes max per test)
-    # Use absolute path to the Python file
-    if timeout 600 python3 "$PYTHON_FILE" 2>&1; then
-        echo "  ✓ Test passed"
+
+    # Use timeout with progress reporting
+    START_TIME=$(date +%s)
+    if timeout 600 python3 "$PYTHON_FILE" | tee /tmp/notebook_output_$$.log; then
+        END_TIME=$(date +%s)
+        ELAPSED=$((END_TIME - START_TIME))
+        echo "  ✓ Test passed (completed in ${ELAPSED}s)"
         PASSED_TESTS=$((PASSED_TESTS + 1))
     else
         EXIT_CODE=$?
+        END_TIME=$(date +%s)
+        ELAPSED=$((END_TIME - START_TIME))
         if [ $EXIT_CODE -eq 124 ]; then
-            echo "  ✗ Test timed out (exceeded 10 minutes)"
+            echo "  ✗ Test timed out (exceeded 600 seconds, ran for ${ELAPSED}s)"
+            echo "  Last 20 lines of output:"
+            tail -20 /tmp/notebook_output_$$.log 2>/dev/null || echo "  (no output captured)"
         else
-            echo "  ✗ Test failed with exit code $EXIT_CODE"
+            echo "  ✗ Test failed with exit code $EXIT_CODE (ran for ${ELAPSED}s)"
+            echo "  Last 20 lines of output:"
+            tail -20 /tmp/notebook_output_$$.log 2>/dev/null || echo "  (no output captured)"
         fi
         FAILED_TESTS=$((FAILED_TESTS + 1))
     fi
+    rm -f /tmp/notebook_output_$$.log
 
     echo ""
 done