Commit Gemfile.lock for reproducible tests #3265
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed a syntax error in the
thrift.gemspec, and committed Gemfile.lock files for both the gem and tests. Gems source switched to https://rubygems.org (from http://).This is a strongly recommended approach according to the Bundler team:
Also helps with Dependabot, which will be able to bump the lock file, while we can relax version requirements in the gemspec.
[skip ci]anywhere in the commit message to free up build resources.