Skip to content

Commit e8ad3e2

Browse files
authored
Merge pull request #458 from danistrebel/feature/fix-sackmesser
Feature/fix sackmesser
2 parents 4dcd548 + a7f9d48 commit e8ad3e2

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

references/cloud-logging-shared-flow/pipeline.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ if [ "$EXISTING_EMAIL" != "$SA_EMAIL" ]; then
3131
--role="roles/logging.logWriter"
3232
fi
3333

34-
35-
3634
sackmesser deploy --googleapi -d "$SCRIPTPATH" -t "$APIGEE_TOKEN" --deployment-sa "$SA_EMAIL"
3735
sackmesser deploy --googleapi -d "$SCRIPTPATH/test/logging-example" -t "$APIGEE_TOKEN"
3836

tools/apigee-sackmesser/cmd/deploy/deploy.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ skip_deployment=true #skip maven deploy unless bundle contains proxy or shared f
122122
if [ -d "$temp_folder/apiproxy" ]; then
123123
loginfo "Configuring API Proxy"
124124

125-
if [ ! -f "$temp_folder/apiproxy/*.xml" ]; then
125+
if [ -z "$(find "$temp_folder/apiproxy" -type f -name "*.xml" -maxdepth 1 -mindepth 1)" ]; then
126126
if [ -z "$bundle_name" ]; then
127127
bundle_name=$(basename "$source_dir")
128128
fi
@@ -155,7 +155,7 @@ elif [ -d "$temp_folder/sharedflowbundle" ]; then
155155

156156
skip_deployment=false
157157

158-
if [ ! -f "$temp_folder/sharedflowbundle/*.xml" ]; then
158+
if [ -z "$(find "$temp_folder/sharedflowbundle" -type f -name "*.xml" -maxdepth 1 -mindepth 1)" ]; then
159159
if [ -z "$bundle_name" ]; then
160160
bundle_name=$(basename "$source_dir")
161161
fi

tools/apigee-sackmesser/cmd/export/export.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ fi
4141
loginfo "exporting to $export_folder"
4242
mkdir -p "$export_folder"
4343

44-
sackmesser list "organizations/$organization/sharedflows" | jq -r -c '.[]|.'| while read -r sharedflow; do
44+
sackmesser list "organizations/$organization/sharedflows" | jq -r -c '.[]|. | select((. | length) > 1)' | while read -r sharedflow; do
4545
loginfo "download shared flow: $sharedflow"
4646
mkdir -p "$export_folder/sharedflows/$sharedflow"
4747
latest="$(sackmesser list "organizations/$organization/sharedflows/$sharedflow" | jq '.revision | map(tonumber) | max')"

tools/apigee-sackmesser/cmd/report/report.sh

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ performancequery="organizations/$organization/environments/$environment/stats/ap
9393
performancequery+="?limit=14400&offset=0"
9494
performancequery+="&select=sum(message_count)/3600.0,sum(is_error),avg(target_response_time),avg(total_response_time)"
9595
performancequery+="&timeUnit=day"
96-
PERFORMANCE_Q_START=$(date -u -v1d '+%m/%d/%Y%%2000:00:00' 2&>/dev/null || date -u -d "1 day ago" '+%m/%d/%Y%%2000:00:00' || date -u -d "@$(( $(date +%s ) - 86400 ))" '+%m/%d/%Y%%2000:00:00')
96+
PERFORMANCE_Q_START=$(date -u -v1d '+%m/%d/%Y%%2000:00:00' 2&>/dev/null || date -u -d "1 day ago" '+%m/%d/%Y%%2000:00:00' || date -u -d "@$(( $(date +%s ) - 86400 ))" '+%m/%d/%Y%%2000:00:00' || echo '')
9797
performancequery+="&timeRange=$PERFORMANCE_Q_START~$(date -u '+%m/%d/%Y%%2000:00:00')"
9898
sackmesser list "$performancequery" > "$export_folder/performance-$environment.json"
9999

@@ -182,7 +182,6 @@ do
182182

183183
echo "$linkrevision" > "$export_folder/scratch/proxyrevisions/$proxyname"
184184

185-
186185
if [ -d "$proxyexportpath/apiproxy/policies" ];then
187186
policycount=$(find "$proxyexportpath"/apiproxy/policies/*.xml | wc -l)
188187
else
@@ -224,7 +223,11 @@ echo "<tbody>" >> "$report_html"
224223
while IFS= read -r -d '' policyusage
225224
do
226225
proxyname=$(basename "${policyusage%%-indexed.*}")
227-
linkrevision=$(cat "$export_folder/scratch/proxyrevisions/$proxyname")
226+
if [ -f "$export_folder/scratch/proxyrevisions/$proxyname" ]; then
227+
linkrevision=$(cat "$export_folder/scratch/proxyrevisions/$proxyname")
228+
else
229+
linkrevision="unknown"
230+
fi
228231
echo "<tr>" >> "$report_html"
229232
echo "<th scope=\"row\"><a href=\"$(resource_link "proxies/$proxyname" "$linkrevision")\" target=\"_blank\">$proxyname</a></th>" >> "$report_html"
230233

0 commit comments

Comments
 (0)