Address first set of review

Author: CuriousLearner

postgres/bin/entrypoint.sh

@@ -10,16 +10,14 @@ wait_for_db() {
 
   echo "Waiting for PostgreSQL server to be ready..."
   until psql "$DATABASE_URL" -c '\q' 2>/dev/null || [ "$retries" -eq 0 ]; do
-    echo "PostgreSQL is unavailable - sleeping ($((retries--)) retries left)..."
+    echo "PostgreSQL is unavailable - ($((retries--)) retries left)..."
     sleep "$sleep_time"
   done
 
   if [ "$retries" -eq 0 ]; then
-    echo "ERROR: PostgreSQL server did not become ready in time."
+    echo "ERROR: PostgreSQL server did not respond."
     exit 1
   fi
-
-  echo "PostgreSQL server is ready!"
 }
 
 if [ -z "${DATABASE_URL:-""}" ]; then

postgres/bin/load-from-s3.sh

@@ -20,8 +20,8 @@ fi
 PG_RESTORE="pg_restore-$SERVER_VERSION"
 
 if ! command -v "$PG_RESTORE" &>/dev/null; then
-  echo "Warning: pg_restore for version $SERVER_VERSION is not installed. Defaulting to pg_restore-17."
-  PG_RESTORE="pg_restore-17"
+  echo "Error: $PG_RESTORE not found in PATH." >&2
+  exit 1
 fi
 
 echo "Dropping all objects owned by \"$USER\" in the database..."

postgres/bin/parse_database_url.py

@@ -1,7 +1,6 @@
 #!/usr/bin/env python3
 """Dump out a DATABASE_URL provided in the environment as individual variables"""
 import os
-import sys
 from urllib.parse import urlparse
 
 parsed = urlparse(os.environ["DATABASE_URL"])

postgres/docs/support-newer-postgres-versions.md

@@ -9,5 +9,5 @@
    and running the script against a PostgreSQL 18 server.
 3. Ensure fallback compatibility:
    Test the script with no `SERVER_VERSION` set to confirm it falls back to the latest version.
-4. Update `dump-to-s3.sh` script's `SERVER_VERSION` default value if the new version becomes the default:
+4. Update `load-from-s3.sh` & `dump-to-s3.sh` script's `SERVER_VERSION` default value if the new version becomes the default:
    Change `SERVER_VERSION=${SERVER_VERSION:-17}` to `SERVER_VERSION=${SERVER_VERSION:-18}`.