From 523e1fa7943113ea63c062235176622bfd6fcc10 Mon Sep 17 00:00:00 2001 From: Imtiaz Uddin Date: Mon, 18 May 2026 16:24:57 +0600 Subject: [PATCH] Always render ca.crt and sa.json in objstore secret to allow clearing on upgrade Previously, ca.crt (s3) and sa.json (gcs) were conditionally omitted from the Secret template when their values were empty. This caused helm upgrade to leave stale values in the secret when the fields were removed from values.yaml. Now both fields are always rendered using `| default "" | quote`, ensuring that removing a value in values.yaml explicitly overwrites the secret key with an empty string on the next upgrade. Signed-off-by: Imtiaz Uddin --- charts/ace/templates/platform/objstore-cred.yaml | 6 ++---- charts/outbox-syncer/Chart.yaml | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/charts/ace/templates/platform/objstore-cred.yaml b/charts/ace/templates/platform/objstore-cred.yaml index 6ebb383d0..fc03ccbe6 100644 --- a/charts/ace/templates/platform/objstore-cred.yaml +++ b/charts/ace/templates/platform/objstore-cred.yaml @@ -14,9 +14,7 @@ stringData: {{- if eq $objstore.provider "s3" }} AWS_ACCESS_KEY_ID: '{{ $objstore.s3.AWS_ACCESS_KEY_ID }}' AWS_SECRET_ACCESS_KEY: '{{ $objstore.s3.AWS_SECRET_ACCESS_KEY }}' - {{- if $objstore.s3.CA_CERT_DATA }} - ca.crt: {{ $objstore.s3.CA_CERT_DATA | quote }} - {{- end }} + ca.crt: {{ $objstore.s3.CA_CERT_DATA | default "" | quote }} {{- with $objstore.s3.AWS_REGION }} AWS_REGION: '{{ . }}' {{- end }} @@ -30,7 +28,7 @@ stringData: {{- end }} {{- if eq $objstore.provider "gcs" }} - sa.json: '{{ $objstore.gcs.GOOGLE_SERVICE_ACCOUNT_JSON_KEY }}' + sa.json: {{ $objstore.gcs.GOOGLE_SERVICE_ACCOUNT_JSON_KEY | default "" | quote }} {{- end }} {{- end }} diff --git a/charts/outbox-syncer/Chart.yaml b/charts/outbox-syncer/Chart.yaml index 8c1bcc1ca..04cbb9f33 100644 --- a/charts/outbox-syncer/Chart.yaml +++ b/charts/outbox-syncer/Chart.yaml @@ -3,7 +3,7 @@ name: outbox-syncer description: A Helm chart for Kubernetes type: application version: v2026.4.30 -appVersion: v0.2.0 +appVersion: v0.4.0 home: https://github.com/appscode-cloud icon: https://cdn.appscode.com/images/products/bytebuilders/icons/android-icon-192x192.png sources: