Uncomplicated the logic where we return false in the permissions for creating datasource actions on workspace IDE

Author: tomjose92

app/client/src/ce/utils/BusinessFeatures/permissionPageHelpers.tsx

@@ -176,9 +176,21 @@ export const hasCreateDSActionPermissionInApp = ({
   isEnabled: boolean;
   pagePermissions?: string[];
 }) => {
-  return !ideType || ideType === IDE_TYPE.App
-    ? getHasCreateDatasourceActionPermission(isEnabled, dsPermissions) &&
-        getHasCreateActionPermission(isEnabled, pagePermissions)
-    : ideType !== IDE_TYPE.Workspace &&
-        getHasCreateDatasourceActionPermission(isEnabled, dsPermissions);
+  const hasDatasourcePermission = getHasCreateDatasourceActionPermission(
+    isEnabled,
+    dsPermissions,
+  );
+
+  if (ideType === IDE_TYPE.Workspace) {
+    return false;
+  }
+
+  if (!ideType || ideType === IDE_TYPE.App) {
+    return (
+      hasDatasourcePermission &&
+      getHasCreateActionPermission(isEnabled, pagePermissions)
+    );
+  }
+
+  return hasDatasourcePermission;
 };

app/client/src/entities/Engine/WorkspaceEditorEngine.ts

@@ -16,8 +16,6 @@ import {
   PluginsNotFoundError,
 } from "entities/Engine";
 import type { ReduxAction } from "actions/ReduxActionTypes";
-import { waitForFetchEnvironments } from "ee/sagas/EnvironmentSagas";
-import { fetchingEnvironmentConfigs } from "ee/actions/environmentAction";
 import { getWorkspaceFromId } from "ee/selectors/workspaceSelectors";
 import { fetchAllWorkspaces } from "ee/actions/workspaceActions";
 
@@ -51,18 +49,6 @@ export default class WorkspaceEditorEngine {
         ReduxActionErrorTypes.FETCH_WORKSPACES_ERROR,
       ]);
     }
-
-    // Fetch environment configs for the workspace
-    yield put(
-      fetchingEnvironmentConfigs({
-        workspaceId,
-        editorId: workspaceId,
-        fetchDatasourceMeta: true,
-      }),
-    );
-
-    // Wait for environments to be fetched
-    yield call(waitForFetchEnvironments);
   }
 
   public *setupEngine() {