Skip to content

Commit cc1ea71

Browse files
authored
chore: add code-split for fixing package version change bug with in-memory Git (#41442)
## Description EE Counterpart: appsmithorg/appsmith-ee#8468 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/19896141793> > Commit: 478fefe > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=19896141793&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Wed, 03 Dec 2025 14:41:38 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [x] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved error reporting for missing Git-related resources by including contextual details. * **Refactor** * Reorganized Git routing internals into a new layered implementation to simplify flow and improve reliability. * **Tests** * Updated tests to align with the restructured Git routing implementation. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 1ff537a commit cc1ea71

File tree

4 files changed

+901
-841
lines changed

4 files changed

+901
-841
lines changed

app/server/appsmith-server/src/main/java/com/appsmith/server/artifacts/gitRoute/GitRouteArtifactCE.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ public Mono<Artifact> getArtifact(ArtifactType artifactType, String artifactId)
2525
return switch (artifactType) {
2626
case APPLICATION -> applicationRepository
2727
.findById(artifactId)
28-
.switchIfEmpty(Mono.error(new AppsmithException(AppsmithError.NO_RESOURCE_FOUND)))
28+
.switchIfEmpty(Mono.error(
29+
new AppsmithException(AppsmithError.NO_RESOURCE_FOUND, artifactType, artifactId)))
2930
.map(app -> (Artifact) app);
3031
default -> Mono.error(new AppsmithException(AppsmithError.GIT_ROUTE_HANDLER_NOT_FOUND, artifactType));
3132
};

0 commit comments

Comments
 (0)