-
Notifications
You must be signed in to change notification settings - Fork 197
Feat: add screenshotsGenerated metric across console #2542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5889e8c
feat: add build timeout handling to prevent stuck build UI
HarshMN2345 4ec0298
added for overview page
HarshMN2345 4f3b9d3
copilot suggestion
HarshMN2345 ddf5996
code rabbit clean suggestions
HarshMN2345 f0cae0b
Update src/routes/(console)/project-[region]-[project]/sites/(compone…
HarshMN2345 0ceaed9
inline timeout lookup in getEffectiveBuildStatus and update call sites
HarshMN2345 032f094
package upgrade
HarshMN2345 fc83486
Merge branch 'main' into fix-SER-457-resolve-forever-pending-deployments
HarshMN2345 6a4c4ed
fix: errors
HarshMN2345 37c38c7
Merge branch 'main' into fix-SER-457-resolve-forever-pending-deployments
HarshMN2345 add4296
used realtime
HarshMN2345 b9b49f3
feat(billing, usage): add screenshotsGenerated metric across console
HarshMN2345 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import type { Models } from '@appwrite.io/console'; | ||
|
|
||
| /** | ||
| * Checks if a build has exceeded the maximum build timeout duration | ||
| */ | ||
| function isBuildTimedOut(createdAt: string, status: string, timeoutSeconds: number): boolean { | ||
| if (!['waiting', 'processing', 'building'].includes(status)) { | ||
| return false; | ||
| } | ||
|
|
||
| if (!timeoutSeconds || timeoutSeconds <= 0) { | ||
| return false; | ||
| } | ||
|
|
||
| const created = new Date(createdAt); | ||
| const elapsedSeconds = Math.floor((Date.now() - created.getTime()) / 1000); | ||
|
|
||
| return elapsedSeconds > timeoutSeconds; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the effective status for a build, considering timeout | ||
| */ | ||
| export function getEffectiveBuildStatus( | ||
| originalStatus: string, | ||
| createdAt: string, | ||
| consoleVariables: Models.ConsoleVariables | undefined | ||
| ): string { | ||
| const timeoutSeconds = getBuildTimeoutSeconds(consoleVariables); | ||
| if (isBuildTimedOut(createdAt, originalStatus, timeoutSeconds)) { | ||
| return 'failed'; | ||
| } | ||
| return originalStatus; | ||
| } | ||
|
|
||
| /** | ||
| * Helper to get timeout value from console variables | ||
| */ | ||
| function getBuildTimeoutSeconds(consoleVariables: Models.ConsoleVariables | undefined): number { | ||
| if (!consoleVariables?._APP_COMPUTE_BUILD_TIMEOUT) { | ||
| return 0; | ||
| } | ||
| const timeout = parseInt(String(consoleVariables._APP_COMPUTE_BUILD_TIMEOUT), 10); | ||
| return isNaN(timeout) ? 0 : timeout; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timeout logic never re-runs
Same as in
logsTimer.svelte: the derivedeffectiveStatushas no time-based dependency, so once the component mounts it never re-checks the timeout and deployments stuck inbuilding/processingnever graduate to'failed'. Please introduce a ticking dependency (e.g. a$stateupdated on an interval or aSvelteDate) so the timeout calculation re-executes after the configured threshold.