Skip to content

Commit 9f1f121

Browse files
committed
fix: The navItems are not clickable with vimium (accessibility) (#12813)
- change: drop div + change css Signed-off-by: Michael Fresco <[email protected]>
1 parent 54f36c7 commit 9f1f121

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/components/nav-bar/nav-bar.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@ $nav-break-height-sm: 746px;
3232
margin: 20px 0;
3333
padding-right: 3px;
3434
font-size: 34px;
35+
font-family: inherit;
36+
line-height: 1.5;
37+
display: block;
38+
width: 100%;
3539
color: $white-color;
3640
text-align: center;
3741
cursor: pointer;

src/components/nav-bar/nav-bar.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ export const NavBar: React.FunctionComponent<NavBarProps> = (props: NavBarProps,
3535
<div className='nav-bar__version'>{props.version && props.version()}</div>
3636
{(props.items || []).map((item) => (
3737
<Tooltip content={item.title} placement='right' arrow={true} key={item.path + item.title}>
38-
<div className={classNames('nav-bar__item', { active: isActiveRoute(locationPath, item.path) })}
38+
<button className={classNames('nav-bar__item', { active: isActiveRoute(locationPath, item.path) })}
3939
onClick={() => context.router.history.push(item.path)}>
4040
<i className={item.iconClassName}/>
41-
</div>
41+
</button>
4242
</Tooltip>
4343
))}
4444
</div>

0 commit comments

Comments
 (0)