fix: add archive location if artifact is needed in data source. Fixes #14990

Signed-off-by: oninowang <[email protected]>

Author: jswxstw

docs/fields.md

@@ -2054,8 +2054,6 @@ Outputs hold parameters, artifacts, and results from a step
 
 - [`dag-conditional-parameters.yaml`](https://github.com/argoproj/argo-workflows/blob/main/examples/dag-conditional-parameters.yaml)
 
-- [`data-transformations.yaml`](https://github.com/argoproj/argo-workflows/blob/main/examples/data-transformations.yaml)
-
 - [`exit-handler-with-artifacts.yaml`](https://github.com/argoproj/argo-workflows/blob/main/examples/exit-handler-with-artifacts.yaml)
 
 - [`exit-handler-with-param.yaml`](https://github.com/argoproj/argo-workflows/blob/main/examples/exit-handler-with-param.yaml)

examples/data-transformations.yaml

@@ -38,10 +38,6 @@ spec:
 
         transformation:
           - expression: "filter(data, {# endsWith \"main.log\"})"
-      outputs:
-        artifacts:
-          - name: file
-            path: /file
 
     - name: process-logs
       inputs:

workflow/controller/workflowpod.go

@@ -1205,7 +1205,13 @@ func (woc *wfOperationCtx) addArchiveLocation(ctx context.Context, tmpl *wfv1.Te
 	}
 	archiveLogs := woc.IsArchiveLogs(tmpl)
 	needLocation := archiveLogs
-	for _, art := range append(tmpl.Inputs.Artifacts, tmpl.Outputs.Artifacts...) {
+	artifacts := append(tmpl.Inputs.Artifacts, tmpl.Outputs.Artifacts...)
+	if tmpl.Data != nil {
+		if art, exist := tmpl.Data.Source.GetArtifactIfNeeded(); exist {
+			artifacts = append(artifacts, *art)
+		}
+	}
+	for _, art := range artifacts {
 		if !art.HasLocation() {
 			needLocation = true
 		}