fix!: return latest workflow for retried-persisted workflows #15030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joibel
changed the title
Joibel
requested changes
Nov 11, 2025
Member
Joibel
left a comment
Joibel
left a comment
There was a problem hiding this comment.
What happens if you have an archived and a live (in cluster) workflow?
Signed-off-by: Elliot Gunton <[email protected]>
elliotgunton
force-pushed
the
fix-api-for-retried-persisted-workflows
branch
from
7949cd0 to
1d93618
Compare
Contributor
Author
It will not fall into the archived GetWorkflow path here argo-workflows/server/workflow/workflow_server.go Lines 750 to 752 in 436a8d5 |
Joibel
approved these changes
Nov 12, 2025
|
❌ Cherry-pick failed for 3.7. Please check the workflow logs for details. |
Joibel
pushed a commit
that referenced
this pull request
Nov 12, 2025
(cherry picked from commit e98b6b3) Signed-off-by: Elliot Gunton <[email protected]> Signed-off-by: Alan Clucas <[email protected]>
Joibel
pushed a commit
that referenced
this pull request
Nov 12, 2025
(cherry picked from commit e98b6b3) Signed-off-by: Elliot Gunton <[email protected]> Signed-off-by: Alan Clucas <[email protected]>
Joibel
added a commit
that referenced
this pull request
Nov 12, 2025
…pick #15030 for 3.7) (#15032) Signed-off-by: Elliot Gunton <[email protected]> Signed-off-by: Alan Clucas <[email protected]> Co-authored-by: Elliot Gunton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15015
Modifications
GetWorkflowfunction, just log a debug message insteadOrderBy(-startedat)to the database query so we can retrieve the latest workflow (via the subsequentOnefunction)Verification
Tested with
make start PROFILE=postgres UI=trueand thencurl -k http://localhost:2746/api/v1/workflows/argo/<workflow-name>at each stage described in the issue. If there are multiple persisted workflows with the same name (but different uids) then theGetWorkflowendpoint now return the most recently finished workflow, matching non-archived behaviour.