feat: create rule asyncapi3-channel-servers for v3 core ruleset

Author: aeworxet

.changeset/rich-elephants-applaud.md

@@ -0,0 +1,5 @@
+---
+"@asyncapi/parser": minor
+---
+
+feat: create the rule `asyncapi3-channel-servers` for the v3 rule core ruleset

…c/ruleset/v2/functions/channelServers.ts …/src/ruleset/functions/channelServers.tspackages/parser/src/ruleset/v2/functions/channelServers.ts renamed to packages/parser/src/ruleset/functions/channelServers.ts packages/parser/src/ruleset/v2/functions/channelServers.ts renamed to packages/parser/src/ruleset/functions/channelServers.ts

@@ -4,7 +4,7 @@ import { AsyncAPIFormats } from '../formats';
 import { truthy, pattern } from '@stoplight/spectral-functions';
 
 import { channelParameters } from './functions/channelParameters';
-import { channelServers } from './functions/channelServers';
+import { channelServers } from '../functions/channelServers';
 import { checkId } from './functions/checkId';
 import { messageExamples } from './functions/messageExamples';
 import { asyncApi2MessageExamplesParserRule } from './functions/messageExamples-spectral-rule-v2';

packages/parser/src/ruleset/v2/ruleset.ts

@@ -3,6 +3,7 @@
 import { AsyncAPIFormats } from '../formats';
 import { operationMessagesUnambiguity } from './functions/operationMessagesUnambiguity';
 import { pattern } from '@stoplight/spectral-functions';
+import { channelServers } from '../functions/channelServers';
 
 export const v3CoreRuleset = {
   description: 'Core AsyncAPI 3.x.x ruleset.',
@@ -57,6 +58,16 @@ export const v3CoreRuleset = {
         },
       },
     },
+    'asyncapi3-channel-servers': {
+      description: 'Channel servers must be defined in the "servers" object.',
+      message: '{{error}}',
+      severity: 'error',
+      recommended: true,
+      given: '$',
+      then: {
+        function: channelServers,
+      },
+    },
     'asyncapi3-channel-no-query-nor-fragment': {
       description: 'Channel address should not include query ("?") or fragment ("#") delimiter.',
       severity: 'error',

packages/parser/src/ruleset/v3/ruleset.ts

@@ -0,0 +1,140 @@
+import { testRule, DiagnosticSeverity } from '../../tester';
+
+testRule('asyncapi3-channel-servers', [
+  {
+    name: 'valid case',
+    document: {
+      asyncapi: '3.0.0',
+      servers: {
+        development: {},
+        production: {},
+      },
+      channels: {
+        channel: {
+          servers: ['development'],
+        },
+      },
+    },
+    errors: [],
+  },
+
+  {
+    name: 'valid case - without defined servers',
+    document: {
+      asyncapi: '3.0.0',
+      servers: {
+        development: {},
+        production: {},
+      },
+      channels: {
+        channel: {},
+      },
+    },
+    errors: [],
+  },
+
+  {
+    name: 'valid case - without defined servers in the root',
+    document: {
+      asyncapi: '3.0.0',
+      channels: {
+        channel: {},
+      },
+    },
+    errors: [],
+  },
+
+  {
+    name: 'valid case - without defined channels in the root',
+    document: {
+      asyncapi: '3.0.0',
+      servers: {
+        development: {},
+        production: {},
+      },
+    },
+    errors: [],
+  },
+
+  {
+    name: 'valid case - with empty array',
+    document: {
+      asyncapi: '3.0.0',
+      servers: {
+        development: {},
+        production: {},
+      },
+      channels: {
+        channel: {
+          servers: [],
+        },
+      },
+    },
+    errors: [],
+  },
+
+  {
+    name: 'invalid case',
+    document: {
+      asyncapi: '3.0.0',
+      servers: {
+        development: {},
+        production: {},
+      },
+      channels: {
+        channel: {
+          servers: ['another-server'],
+        },
+      },
+    },
+    errors: [
+      {
+        message: 'Channel contains server that are not defined on the "servers" object.',
+        path: ['channels', 'channel', 'servers', '0'],
+        severity: DiagnosticSeverity.Error,
+      },
+    ],
+  },
+
+  {
+    name: 'invalid case - one server is defined, another one not',
+    document: {
+      asyncapi: '3.0.0',
+      servers: {
+        development: {},
+        production: {},
+      },
+      channels: {
+        channel: {
+          servers: ['production', 'another-server'],
+        },
+      },
+    },
+    errors: [
+      {
+        message: 'Channel contains server that are not defined on the "servers" object.',
+        path: ['channels', 'channel', 'servers', '1'],
+        severity: DiagnosticSeverity.Error,
+      },
+    ],
+  },
+
+  {
+    name: 'invalid case - without defined servers',
+    document: {
+      asyncapi: '3.0.0',
+      channels: {
+        channel: {
+          servers: ['production'],
+        },
+      },
+    },
+    errors: [
+      {
+        message: 'Channel contains server that are not defined on the "servers" object.',
+        path: ['channels', 'channel', 'servers', '0'],
+        severity: DiagnosticSeverity.Error,
+      },
+    ],
+  },
+]);