Remove slot time check interval, it was never used

Author: teor2345

chain-alerter/src/alerts/tests.rs

@@ -17,7 +17,6 @@ use crate::subspace::{
 };
 use anyhow::Ok;
 use std::assert_matches::assert_matches;
-use std::time::Duration;
 use subxt::ext::futures::{FutureExt, StreamExt};
 
 /// The extrinsic and event for a recent sudo call.
@@ -643,7 +642,6 @@ async fn no_expected_test_slot_time_alert() -> anyhow::Result<()> {
     let second_block = mock_block_info(200000, Slot(200));
 
     let mut naive_slot_time_monitor = MemorySlotTimeMonitor::new(SlotTimeMonitorConfig::new(
-        Duration::from_secs(1),
         2,      // max_block_buffer - small buffer for testing
         2f64,   // slow_slots_threshold
         0.1f64, // fast_slots_threshold
@@ -676,7 +674,6 @@ async fn expected_test_slot_time_alert() -> anyhow::Result<()> {
     let second_block = mock_block_info(200000, Slot(200));
 
     let mut strict_slot_time_monitor = MemorySlotTimeMonitor::new(SlotTimeMonitorConfig::new(
-        Duration::from_secs(1),
         2,      // max_block_buffer - small buffer for testing
         0.2f64, // slow_slots_threshold
         0.1f64, // fast_slots_threshold
@@ -732,7 +729,6 @@ async fn test_slot_time_above_slow_threshold() -> anyhow::Result<()> {
     let second_block = mock_block_info(200000, Slot(101));
 
     let mut slot_time_monitor = MemorySlotTimeMonitor::new(SlotTimeMonitorConfig::new(
-        Duration::from_secs(1),
         2,       // max_block_buffer - small buffer for testing
         2f64,    // slow_slots_threshold
         0.01f64, // fast_slots_threshold
@@ -788,7 +784,6 @@ async fn test_slot_time_below_fast_threshold() -> anyhow::Result<()> {
     let second_block = mock_block_info(200000, Slot(200));
 
     let mut slot_time_monitor = MemorySlotTimeMonitor::new(SlotTimeMonitorConfig::new(
-        Duration::from_secs(1),
         2,     // max_block_buffer - small buffer for testing
         10f64, // slow_slots_threshold
         2f64,  // fast_slots_threshold
@@ -840,7 +835,6 @@ async fn test_slot_time_alerts_ignored_during_startup() -> anyhow::Result<()> {
     let second_block = mock_block_info(2000, Slot(200));
 
     let mut slot_time_monitor = MemorySlotTimeMonitor::new(SlotTimeMonitorConfig::new(
-        Duration::from_secs(1),
         2,      // max_block_buffer - small buffer for testing
         0.5f64, // slow_slots_threshold (0.1 < 0.5, so would normally trigger)
         0.1f64, // fast_slots_threshold
@@ -874,7 +868,6 @@ async fn test_slot_time_alerts_not_triggered_when_buffer_not_full() -> anyhow::R
     let second_block = mock_block_info(200000, Slot(200));
 
     let mut slot_time_monitor = MemorySlotTimeMonitor::new(SlotTimeMonitorConfig::new(
-        Duration::from_secs(1),
         3,      // max_block_buffer - need 3 blocks to fill buffer
         0.5f64, // slow_slots_threshold (1.0 > 0.5, so would trigger if buffer was full)
         0.1f64, // fast_slots_threshold

chain-alerter/src/main.rs

@@ -26,8 +26,8 @@ use crate::farming_monitor::{
 use crate::format::fmt_duration;
 use crate::slack::{SLACK_OAUTH_SECRET_PATH, SlackClientInfo};
 use crate::slot_time_monitor::{
-    DEFAULT_CHECK_INTERVAL, DEFAULT_FAST_SLOTS_THRESHOLD, DEFAULT_MAX_BLOCK_BUFFER,
-    DEFAULT_SLOW_SLOTS_THRESHOLD, SlotTimeMonitorConfig,
+    DEFAULT_FAST_SLOTS_THRESHOLD, DEFAULT_MAX_BLOCK_BUFFER, DEFAULT_SLOW_SLOTS_THRESHOLD,
+    SlotTimeMonitorConfig,
 };
 use crate::subspace::{
     BlockInfo, BlockLink, BlockNumber, BlockPosition, BlockSubscription, LOCAL_SUBSPACE_NODE_URL,
@@ -1020,7 +1020,6 @@ async fn check_best_blocks(
 
     // Slot time monitor is used to check if the slot time is within the expected range.
     let mut slot_time_monitor = MemorySlotTimeMonitor::new(SlotTimeMonitorConfig::new(
-        DEFAULT_CHECK_INTERVAL,
         DEFAULT_MAX_BLOCK_BUFFER,
         DEFAULT_SLOW_SLOTS_THRESHOLD,
         DEFAULT_FAST_SLOTS_THRESHOLD,

chain-alerter/src/slot_time_monitor.rs

@@ -7,7 +7,6 @@ use crate::alerts::{Alert, AlertKind, BlockCheckMode};
 use crate::subspace::BlockInfo;
 use anyhow::Ok;
 use std::collections::VecDeque;
-use std::time::Duration;
 use tokio::sync::mpsc;
 use tracing::warn;
 
@@ -24,11 +23,9 @@ pub const DEFAULT_SLOW_SLOTS_THRESHOLD: f64 = 1.10;
 pub const DEFAULT_FAST_SLOTS_THRESHOLD: f64 = 0.94;
 
 /// The default maximum block buffer size.
+/// The check interval is approximately 6 times this number (the target block time is 6 seconds).
 pub const DEFAULT_MAX_BLOCK_BUFFER: usize = 100;
 
-/// The default check interval for the slot time monitor.
-pub const DEFAULT_CHECK_INTERVAL: Duration = Duration::from_secs(600);
-
 /// Interface for slot time monitors that consume blocks and perform checks.
 pub trait SlotTimeMonitor {
     /// Ingest a block and update internal state; may emit alerts.
@@ -43,8 +40,6 @@ pub trait SlotTimeMonitor {
 /// Configuration for the slot time monitor.
 #[derive(Clone, Debug)]
 pub struct SlotTimeMonitorConfig {
-    /// Interval between checks of slot timing.
-    pub check_interval: Duration,
     /// Maximum block buffer
     pub max_block_buffer: usize,
     /// Minimum threshold for alerting based on time-per-slot ratio.
@@ -90,19 +85,12 @@ pub enum AlertingStatus {
 impl SlotTimeMonitorConfig {
     /// Create a new slot time monitor configuration with the provided parameters.
     pub fn new(
-        check_interval: Duration,
         max_block_buffer: usize,
         slow_slots_threshold: f64,
         fast_slots_threshold: f64,
         alert_tx: mpsc::Sender<Alert>,
     ) -> Self {
-        assert!(
-            u64::try_from(check_interval.as_millis()).is_ok(),
-            "unexpectedly large check interval"
-        );
-
         Self {
-            check_interval,
             max_block_buffer,
             slow_slots_threshold,
             fast_slots_threshold,