Refactor #91
Refactor #91
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| format!("Invalid bundle at block: {n}") | ||
| } | ||
| crate::event_types::SlashedReason::BadExecutionReceipt(h) => { | ||
| format!("Bad execution receipt: 0x{:?}", hex::encode(h)) |
There was a problem hiding this comment.
Bug: Debug Format Quotes Hex Strings
Using {:?} debug format on hex::encode(h) will wrap the hex string in quotes, producing output like Bad execution receipt: 0x"abc123" instead of Bad execution receipt: 0xabc123. The format specifier should be {} not {:?}.
| fn remove_header_until(&mut self, number: BlockNumber) { | ||
| let mut to_remove = number; | ||
| while let Some(hashes) = self.block_number_hashes.remove(&to_remove) { | ||
| debug!("Removing header from cache: {number}"); |
There was a problem hiding this comment.
Bug: Debug Log: Static Number, Not Dynamic
The debug log uses {number} which is the function parameter that never changes, instead of {to_remove} which is the actual block number being removed in each loop iteration. This causes all log messages in the loop to show the same number rather than the actual number being removed.
| enacted, | ||
| retracted: retracted.into_iter().rev().collect(), | ||
| common_block: tree_route.common_block().clone(), | ||
| }); |
There was a problem hiding this comment.
Bug: Data Truncation Impacts Reorg Alerts
The enacted vector has its last element removed by pop() on line 287, then the mutated vector (missing the current best block) is moved into ReorgData on line 297. This causes reorg alerts to report incomplete information, missing the latest enacted block from the reorg data.
No description provided.