Catch 500 error for external request

Move them to 400 and log internally

Author: avdata99

changes/9201.misc

@@ -0,0 +1 @@
+Do not respond with a 500 error to external requests

ckan/views/util.py

@@ -1,12 +1,16 @@
 # encoding: utf-8
 
+import logging
 from flask import Blueprint
+from werkzeug.routing import BuildError as FlaskRouteBuildError
 
 import ckan.lib.base as base
 from ckan.lib.helpers import helper_functions as h
 from ckan.common import _, request
 from ckan.types import Response
 
+
+log = logging.getLogger(__name__)
 util = Blueprint(u'util', __name__)
 
 
@@ -20,7 +24,13 @@ def internal_redirect() -> Response:
 
     url = url.replace('\r', ' ').replace('\n', ' ').replace('\0', ' ')
     if h.url_is_local(url):
-        return h.redirect_to(url)
+        try:
+            response = h.redirect_to(url)
+        except FlaskRouteBuildError:
+            log.error(f'Error building redirect URL: {url}')
+            base.abort(400, _('Invalid URL'))
+        return response
+
     else:
         base.abort(403, _(u'Redirecting to external site is not allowed.'))