fix: properly guard lifecycle result callbacks by generation

Author: aws-kevinrickard

src/main/java/com/aws/greengrass/lifecyclemanager/GenericExternalService.java

@@ -383,8 +383,8 @@ protected void startup() throws InterruptedException {
                     logger.atInfo().kv(EXIT_CODE, exit).log("Startup script exited");
                     separateLogger.atInfo().kv(EXIT_CODE, exit).log("Startup script exited");
                     State state = getState();
-                    if (startingStateGeneration == getStateGeneration() && State.STARTING.equals(state)
-                            || State.RUNNING.equals(state)) {
+                    if (startingStateGeneration == getStateGeneration()
+                            && (State.STARTING.equals(state) || State.RUNNING.equals(state))) {
                         if (exit == 0 && State.STARTING.equals(state)) {
                             reportState(State.RUNNING);
                         } else if (exit != 0) {
@@ -543,7 +543,7 @@ private void handleRunScript() throws InterruptedException {
             if (timeout != null) {
                 Exec processToClose = runResult.getExec();
                 context.get(ScheduledExecutorService.class).schedule(() -> {
-                    if (processToClose.isRunning()) {
+                    if (processToClose.isRunning()) { // TODO: Should we have a generation check here as well?
                         try {
                             logger.atWarn("service-run-timed-out")
                                     .log("Service failed to run within timeout, calling close in process");