TokenProvider::cache does not work

[hillcrest-reedley]

Describe the bug

The TokenProvider::cache method has a serious bug that prevents it from working.

When reading the cache, the code looks for the cache value to be an array containing a key named "token", but when saving to the cache, it directly writes the token to the cache, not an array.

As a result, the cached token is never found and the provider method is invoked every time.

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

Cached value should be properly returned.

Current Behavior

Cached value is never found.

Reproduction Steps

Create a TokenProvider cache

Possible Solution

Match the set and get behavior with common keys.

Additional Information/Context

No response

SDK version used

3.351.4

Environment details (Version of PHP (php -v)? OS name and version, etc.)

php 8.4, Amazon Linux

[hillcrest-reedley]

--- a/vendor/aws/aws-sdk-php/src/Token/TokenProvider.php
+++ b/vendor/aws/aws-sdk-php/src/Token/TokenProvider.php
@@ -214,7 +214,7 @@ public static function cache(
                 ) {
                     $cache->set(
                         $cacheKey,
-                        $token,
+                        ['token' => $token],
                         null === $token->getExpiration() ?
                             0 : $token->getExpiration() - time()
                     );

[hillcrest-reedley]

This has potential cost impact as it increases the number of API calls to retrieve new tokens.

[stobrien89]

Hi @hillcrest-reedley,

Sorry to hear about the issues. I'm looking into this right now. We'll have a fix available ASAP

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

[stobrien89]

@hillcrest-reedley,

#3176 has been merged and will be available in today's release. Added you as a co-contributor for the fix snippet you included. Let us know if you have any issues after upgrading.