PHP 8.5 deprecation warning when using S3's determineBucketRegion method

[rameshvenk]

Describe the bug

When using the S3 module, the following deprecation warning is printed

PHP Deprecated:  Using null as an array offset is deprecated, use an empty string instead in /tmp/php/vendor/aws/aws-sdk-php/src/RetryMiddleware.php on line 166

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

Fix deprecation when using php 8.5

Current Behavior

The code runs fine, but a warning is printed

PHP Deprecated:  Using null as an array offset is deprecated, use an empty string instead

Reproduction Steps

<?php
require_once __DIR__ . '/vendor/autoload.php';

use Aws\S3\S3Client;


$all_buckets = [];
$s3 = new S3Client(
    [
        'version' => 'latest',
        'region' => 'us-east-1'
    ]
);

$paginator = $s3->getPaginator("ListBuckets");
foreach ($paginator as $page) {
    foreach ($page['Buckets'] as $bucket) {
      $s3->determineBucketRegion($bucket['Name']); // <-- this seems to be triggering the error
    }
}

Possible Solution

No response

Additional Information/Context

No response

SDK version used

3.363.0

Environment details (Version of PHP (php -v)? OS name and version, etc.)

PHP 8.5.0 on MacOS M1, Sequoia 15.7.1

[stobrien89]

Hi @rameshvenk,

Sorry to hear about the issues. I opened #3179 a while ago to handle things like this, but seems like this is not a condition that occurs in our tests. Could you provide a stack trace if available, or the output of the call after adding 'debug' => true to your client config? For the latter, be sure to redact any sensitive information like account numbers.

[rameshvenk]

Hi @stobrien89
Thank you for the response!
While I work on sanitizing the log output (which is considerably long), I thought I'd post the relevant section in the debug output which has the deprecation message

<- Leaving step sign, name 'retry'
----------------------------------

  no changes
  Inclusive step time: 0.18960309028625


Deprecated: Using null as an array offset is deprecated, use an empty string instead in /tmp/php/vendor/aws/aws-sdk-php/src/RetryMiddleware.php on line 166

[yenfryherrerafeliz]

Thanks @rameshvenk for the logs. We may need to search for also other places where an array offset maybe null to avoid the warning. In this particular case, the error comes from here, and it looks like the aws error code is null but we try to find it in $errorCodes. I will coordinate with @stobrien89 for addressing this as part of our PHP 8.5 support PR. I will make sure to keep you posted here.

Thanks!