Fix :checksum_mode param in S3::FileDownloader
#3318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3317
Context
When we introduced new request/response checksum configuration options, checksum validation was determined at the client config level. However, documentation on
FileDownloaderimplies that setting:checksum_modeto"DISABLED"will disable the response checksum validation.The Problem
• Even when
:checksum_modewas set to "DISABLED", checksums were still being calculated silently due to the client's config setting for:response_checksum_validation• Recent FileDownloader optimizations added parameter validation that now incorrectly passes the deprecated
checksum_mode: "DISABLED"to HEAD/GET object operations, causing errors ("DISABLED"is not a valid value)Proposed solution
In response, this PR addresses the following:
:checksum_modeparameter in favor of the client's:response_checksum_validationconfiguration:checksum_modeis set to"DISABLED", shows a deprecation warning and skips the parameter to prevent errorsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the
CHANGELOG.mdfile (at corresponding gem). For the description entry, please make sure it lives in one line and starts withFeatureorIssuein the correct format.For generated code changes, please checkout below instructions first:
https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md
Thank you for your contribution!