Skip to content

Conversation

@jterapin
Copy link
Contributor

@jterapin jterapin commented Nov 7, 2025

#3317

Context

When we introduced new request/response checksum configuration options, checksum validation was determined at the client config level. However, documentation on FileDownloader implies that setting :checksum_mode to "DISABLED" will disable the response checksum validation.

The Problem

• Even when :checksum_mode was set to "DISABLED", checksums were still being calculated silently due to the client's config setting for :response_checksum_validation

• Recent FileDownloader optimizations added parameter validation that now incorrectly passes the deprecated checksum_mode: "DISABLED" to HEAD/GET object operations, causing errors ("DISABLED" is not a valid value)

Proposed solution

In response, this PR addresses the following:

  • Deprecates the :checksum_mode parameter in favor of the client's :response_checksum_validation configuration
  • When :checksum_mode is set to "DISABLED", shows a deprecation warning and skips the parameter to prevent errors
  • Updates documentation for clarity on proper checksum configuration

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

  1. To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the CHANGELOG.md file (at corresponding gem). For the description entry, please make sure it lives in one line and starts with Feature or Issue in the correct format.

  2. For generated code changes, please checkout below instructions first:
    https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md

Thank you for your contribution!

@jterapin jterapin marked this pull request as ready for review November 10, 2025 15:14
@jterapin jterapin changed the title [Do not merge] Fix :checksum_mode param in S3::FileDownloader Fix :checksum_mode param in S3::FileDownloader Nov 10, 2025
@jterapin jterapin merged commit 089f2f0 into version-3 Nov 10, 2025
27 checks passed
@jterapin jterapin deleted the fix-disable-checksum-response branch November 10, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants