New: add pre-commit hooks and CI improvements

- Add comprehensive pre-commit configuration
  - Trailing whitespace trimming
  - End-of-file fixing
  - Mixed line ending fixes (LF)
  - Executable shebangs validation
  - Private key detection
  - ShellCheck validation
  - Bash syntax checking
- Update GitHub Actions workflow
  - Add bash syntax check step
  - Set ShellCheck severity to warning
- Fix ShellCheck warnings in dupe.sh
  - SC2155: Separate declaration and assignment
  - Add shellcheck disable comments for intentional word splitting
- Fix ShellCheck SC2207 in sonarr_dupefinder.sh
- Make dupefinder scripts executable
- Update jdupes command path to /usr/local/bin/jdupes
- Add xseed.sh to .gitignore

Author: bakerboy448

.github/workflows/shellcheck.yml

@@ -13,5 +13,8 @@ jobs:
     - name: Install ShellCheck
       run: sudo apt-get install -y shellcheck
 
+    - name: Bash Syntax Check
+      run: find . -type f -name "*.sh" -exec bash -n {} \;
+
     - name: Run ShellCheck
-      run: find . -type f -name "*.sh" -exec shellcheck {} +
+      run: find . -type f -name "*.sh" -exec shellcheck --severity=warning {} +

.gitignore

@@ -351,3 +351,4 @@ MigrationBackup/
 
 # Ignore .env
 .env
+xseed.sh

.pre-commit-config.yaml

@@ -0,0 +1,38 @@
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v5.0.0
+    hooks:
+      - id: trailing-whitespace
+        name: trim trailing whitespace
+      - id: end-of-file-fixer
+        name: fix end of files
+      - id: check-added-large-files
+        name: check for added large files
+      - id: check-merge-conflict
+        name: check for merge conflicts
+      - id: detect-private-key
+        name: detect private key
+      - id: mixed-line-ending
+        name: mixed line ending
+        args: ['--fix=lf']
+      - id: check-executables-have-shebangs
+        name: check executables have shebangs
+      - id: check-shebang-scripts-are-executable
+        name: check shebang scripts are executable
+
+  - repo: https://github.com/shellcheck-py/shellcheck-py
+    rev: v0.10.0.1
+    hooks:
+      - id: shellcheck
+        name: shellcheck
+        args: ['--severity=warning']
+        exclude: '^\.env'
+
+  - repo: local
+    hooks:
+      - id: bash-syntax
+        name: bash syntax check
+        entry: bash -n
+        language: system
+        types: [shell]
+        exclude: '^\.env'

.secrets.baseline

@@ -3,4 +3,4 @@
         "hashdb",
         "zfsburn"
     ]
-}
+}

.vscode/settings.json

@@ -24,14 +24,15 @@ JDUPES_OUTPUT_LOG=${JDUPES_OUTPUT_LOG:-"/mnt/data/jdupes.log"}
 JDUPES_SOURCE_DIR=${JDUPES_SOURCE_DIR:-"/mnt/data/media/"}
 JDUPES_DESTINATION_DIR=${JDUPES_DESTINATION_DIR:-"/mnt/data/torrents/"}
 JDUPES_HASH_DB=${JDUPES_HASH_DB:-"/.config/jdupes_hashdb"}
-JDUPES_COMMAND=${JDUPES_COMMAND:-"/usr/bin/jdupes"}
+JDUPES_COMMAND=${JDUPES_COMMAND:-"/usr/local/bin/jdupes"}
 JDUPES_EXCLUDE_DIRS=${JDUPES_EXCLUDE_DIRS:-"-X nostr:.RecycleBin -X nostr:.trash"}
 JDUPES_INCLUDE_EXT=${JDUPES_INCLUDE_EXT:-"mp4,mkv,avi"}
 DEBUG=${DEBUG:-"false"}
 
 find_duplicates() {
     local log_file="$JDUPES_OUTPUT_LOG"
-    local start_time=$(date +%s)
+    local start_time
+    start_time=$(date +%s)
     echo "[$(date +"%Y-%m-%d %H:%M:%S")] Duplicate search started" | tee -a "$log_file"
 
     if [ "$DEBUG" == "true" ]; then
@@ -40,9 +41,11 @@ find_duplicates() {
     fi
 
     local results
+    # shellcheck disable=SC2086
     results=$("$JDUPES_COMMAND" $JDUPES_EXCLUDE_DIRS -X onlyext:"$JDUPES_INCLUDE_EXT" -r -M -y "$JDUPES_HASH_DB" "$JDUPES_SOURCE_DIR" "$JDUPES_DESTINATION_DIR")
 
     if [[ $results != *"No duplicates found."* ]]; then
+        # shellcheck disable=SC2086
         "$JDUPES_COMMAND" $JDUPES_EXCLUDE_DIRS -X onlyext:"$JDUPES_INCLUDE_EXT" -r -L -y "$JDUPES_HASH_DB" "$JDUPES_SOURCE_DIR" "$JDUPES_DESTINATION_DIR" >>"$log_file"
     fi
 
@@ -51,7 +54,8 @@ find_duplicates() {
     fi
 
     parse_jdupes_output "$results" "$log_file"
-    local finish_time=$(date +%s)
+    local finish_time
+    finish_time=$(date +%s)
     local run_time=$((finish_time - start_time))
     echo "[$(date +"%Y-%m-%d %H:%M:%S")] Duplicate search completed in ${run_time}s" | tee -a "$log_file"
 }

dupe.sh

@@ -4,9 +4,10 @@ directory=${1:-.}  # Use provided directory or default to current directory
 
 find "$directory" -type d | while read -r dir; do
     # Extract all matching filenames in the directory
-files=($(find "$dir" -maxdepth 1 -type f -regextype posix-extended \
-    \( -iname "*.mp4" -o -iname "*.mkv" -o -iname "*.avi" -o -iname "*.mov" -o -iname "*.wmv" -o -iname "*.flv" -o -iname "*.webm" -o -iname "*.mpg" -o -iname "*.mpeg" \) \
-    -regex ".*\([0-9]{4}\).*S[0-9]{2}E([0-9]{2}).*" | sed -E 's/.*E([0-9]{2}).*/\1/'))
+    # shellcheck disable=SC2207
+    files=($(find "$dir" -maxdepth 1 -type f -regextype posix-extended \
+        \( -iname "*.mp4" -o -iname "*.mkv" -o -iname "*.avi" -o -iname "*.mov" -o -iname "*.wmv" -o -iname "*.flv" -o -iname "*.webm" -o -iname "*.mpg" -o -iname "*.mpeg" \) \
+        -regex ".*\([0-9]{4}\).*S[0-9]{2}E([0-9]{2}).*" | sed -E 's/.*E([0-9]{2}).*/\1/'))
 
     # Count occurrences of each episode number
     declare -A ep_count