Skip to content

Commit 7f6aeb5

Browse files
Fix review suggestions
1 parent f8a6b46 commit 7f6aeb5

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/xml/XmlTreeBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ private void readPI(XMLStreamReader xmlStreamReader) {
164164

165165
public static void addXmlDeclaration(XMLStreamReader reader, Deque<List<BXml>> siblingDeque) {
166166
String version = reader.getVersion();
167-
String encoding = reader.getEncoding();
167+
String encoding = reader.getCharacterEncodingScheme();
168168
boolean standalone = reader.isStandalone();
169169

170170
StringBuilder piData = new StringBuilder();

tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/types/xml/XMLLiteralTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ public void testXMLLiteralWithExtraDollarSigns() {
424424
public void testXMLToString() {
425425
BXml xml = XmlFactory.parse("<?xml version=\"1.0\" encoding=\"UTF-8\"?>" +
426426
"<!DOCTYPE foo [<!ELEMENT foo ANY ><!ENTITY data \"Example\" >]><foo>&data;</foo>");
427-
Assert.assertEquals(xml.toString(), "<?xml version=\"1.0\"?><foo>Example</foo>");
427+
Assert.assertEquals(xml.toString(), "<?xml version=\"1.0\" encoding=\"UTF-8\"?><foo>Example</foo>");
428428
}
429429

430430
@Test(dataProvider = "function-name-provider")

tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/types/xml/XMLLiteralWithNamespacesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ public void testXMLSerialize() {
204204
public void testXMLToString() {
205205
BXml xml = XmlFactory.parse("<?xml version=\"1.0\" encoding=\"UTF-8\"?>" +
206206
"<!DOCTYPE foo [<!ELEMENT foo ANY ><!ENTITY data \"Example\" >]><foo>&data;</foo>");
207-
Assert.assertEquals(xml.toString(), "<?xml version=\"1.0\"?><foo>Example</foo>");
207+
Assert.assertEquals(xml.toString(), "<?xml version=\"1.0\" encoding=\"UTF-8\"?><foo>Example</foo>");
208208
}
209209

210210
@Test (dataProvider = "xmlValueFunctions")

0 commit comments

Comments
 (0)