Skip to content

Replace JUnit-style asserts with TestNG Assert in tests #44377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Better-Boy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace JUnit-style asserts with TestNG Assert in tests #44377

Better-Boy wants to merge 1 commit into from

Conversation

@Better-Boy
Copy link

@Better-Boy Better-Boy commented Oct 24, 2025

Purpose

Fixes ##41480

@Better-Boy
Copy link
Author

Better-Boy commented Oct 24, 2025

Currently, only assert statements in test files are updated. Once this is approved, I'll work on replacing assert statement in source code.

@TharmiganK @keizer619 @gimantha

@Better-Boy
Copy link
Author

Better-Boy commented Oct 30, 2025 •
edited
Loading

Adding my discord questions regarding this issue that are still unanswered -

@Better-Boy
Copy link
Author

Better-Boy commented Oct 31, 2025

@TharmiganK / @keizer619 it's been over a week but still no review

@dulajdilshan
Copy link
Contributor

dulajdilshan commented Nov 21, 2025

@Better-Boy

The PR title and commit messages do not follow the best practices we commonly use. Please follow Contribution Guidelines. Also, please check other closed PRs for a reference.

dulajdilshan
dulajdilshan reviewed Nov 21, 2025
View reviewed changes
Copy link
Contributor

@dulajdilshan dulajdilshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is LGTM. But please change the PR title and reword commit messages.

@Better-Boy Better-Boy changed the title replace assert statements with testng Assert in test files Replace JUnit-style asserts with TestNG Assert in tests Nov 22, 2025
@Better-Boy
Copy link
Author

Better-Boy commented Nov 22, 2025

Implementation is LGTM. But please change the PR title and reword commit messages.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dulajdilshan dulajdilshan dulajdilshan left review comments

@gimantha gimantha gimantha approved these changes

@MaryamZi MaryamZi Awaiting requested review from MaryamZi MaryamZi is a code owner

@azinneera azinneera Awaiting requested review from azinneera azinneera is a code owner

@KavinduZoysa KavinduZoysa Awaiting requested review from KavinduZoysa KavinduZoysa is a code owner

@warunalakshitha warunalakshitha Awaiting requested review from warunalakshitha warunalakshitha is a code owner

@sameerajayasoma sameerajayasoma Awaiting requested review from sameerajayasoma sameerajayasoma is a code owner

@keizer619 keizer619 Awaiting requested review from keizer619 keizer619 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Better-Boy @dulajdilshan @gimantha