feat: add block metering RPC endpoints #216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add base_meterBlockByHash and base_meterBlockByNumber RPC methods that re-execute a block and return timing metrics for EVM execution and state root calculation. - Add MeterBlockResponse and MeterBlockTransactions types - Rename meter module to bundle, add new block module for block metering - Include per-transaction timing and gas usage data
Collaborator
🟡 Heimdall Review Status
|
BrianBland
reviewed
Dec 3, 2025
Comment on lines
+69
to
+73
| let signer = tx | ||
| .recover_signer() | ||
| .map_err(|e| eyre!("Failed to recover signer for tx {}: {}", tx_hash, e))?; | ||
| let recovered_tx = | ||
| alloy_consensus::transaction::Recovered::new_unchecked(tx.clone(), signer); |
There was a problem hiding this comment.
I would expect signer recovery to not be part of the metered tx execution time. This is something that can always be parallelized, so we should probably record this separately.
| let _state_root = state_provider | ||
| .state_root(hashed_state) | ||
| .map_err(|e| eyre!("Failed to calculate state root: {}", e))?; | ||
| let state_root_time = state_root_start.elapsed().as_micros(); |
There was a problem hiding this comment.
This may depend heavily on the age of the block, as historical tries may need to be fully recomputed from state diffs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add base_meterBlockByHash and base_meterBlockByNumber RPC methods that re-execute a block and return timing metrics for EVM execution and state root calculation.