Skip to content

Commit a6a12e9

Browse files
committed
docs: //pkg:bzl_srcs update deps.
This change updates deps for //pkg:bzl_srcs to include paths and rules_python, which comes from the individual rules. This bzl_library is next to the .bzl files. Users of rules_pkg may build stardoc for their own extensions by relying on this bzl_library directly. This change deletes the unnecessary starlark_library rule, because starlark_library itself already creates the non-dev dependency from rules_pkg to skylib. A user of rules_pkg will have to have skylib anyways. So let's just use skylib's bzl_library directly. It is okay to put non .bzl files in bzl_library. Test: locally update latest.md, no significant difference other than small changes due to the file being outdated in the first place. Link: #897
1 parent 5c6aec6 commit a6a12e9

3 files changed

Lines changed: 8 additions & 39 deletions

File tree

doc_build/BUILD

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,9 @@ bzl_library(
116116
name = "rules_pkg_lib",
117117
srcs = [
118118
"//:version.bzl",
119+
],
120+
deps = [
119121
"//pkg:bzl_srcs",
120-
"@bazel_skylib//lib:paths",
121122
],
122123
visibility = ["//visibility:public"],
123124
)

pkg/BUILD

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
load("@rules_pkg//pkg/private:make_starlark_library.bzl", "starlark_library")
16-
1715
# -*- coding: utf-8 -*-
16+
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
1817
load("@rules_python//python:defs.bzl", "py_binary", "py_library")
1918

2019
package(default_applicable_licenses = ["//:license"])
@@ -51,7 +50,7 @@ filegroup(
5150
],
5251
)
5352

54-
starlark_library(
53+
bzl_library(
5554
name = "bzl_srcs",
5655
srcs = [
5756
":standard_package",
@@ -62,6 +61,10 @@ starlark_library(
6261
"//pkg/private/zip:standard_package",
6362
"//pkg/releasing:standard_package",
6463
],
64+
deps = [
65+
"@rules_python//python:defs_bzl",
66+
"@bazel_skylib//lib:paths",
67+
],
6568
visibility = ["//visibility:public"],
6669
)
6770

pkg/private/make_starlark_library.bzl

Lines changed: 0 additions & 35 deletions
This file was deleted.

0 commit comments

Comments
 (0)