Fixed minMinionVersion calculations + added doc to compareVersions

Request: MO
Change-Id: I9342170a16d3ab173d0c7a3452f24ab9adc9ebb7

Author: TheTechnolog

ui/webapp/src/app/modules/core/utils/version.utils.ts

@@ -12,13 +12,16 @@ export function convert2String(version: Version): string {
 
 /**
  * Compares two versions. Ignores qualifiers.
+ * @param a the first Version to compare
+ * @param b the second Version to compare
+ * @returns a positive number if Version a is newer than Version b, a negative number if Version a is older than Version b, and exactly 0 if they are the same Version
  */
 export function compareVersions(a: Version, b: Version): number {
   if (a.major !== b.major) {
-      return a.major - b.major;
+    return a.major - b.major;
   }
   if (a.minor !== b.minor) {
-      return a.minor - b.minor;
+    return a.minor - b.minor;
   }
   return a.micro - b.micro;
-}
+}

ui/webapp/src/app/modules/panels/instances/components/add-instance/add-instance.component.ts

@@ -182,7 +182,7 @@ export class AddInstanceComponent implements OnInit, OnDestroy, DirtyableDialog
     if (minimumVersion) {
       const currentVersion = this.cfg?.config?.version;
       if (currentVersion) {
-        if (compareVersions(minimumVersion, currentVersion) < 0) {
+        if (compareVersions(currentVersion, minimumVersion) >= 0) {
           this.addInstanceButtonDisabledMessage.set(null);
         } else {
           this.addInstanceButtonDisabledMessage.set(

ui/webapp/src/app/modules/panels/instances/components/instance-settings/product-update/update-action/update-action.component.ts

@@ -49,7 +49,7 @@ export class UpdateActionComponent implements OnInit, CellComponent<ProductDto,
     if (minimumVersion) {
       const currentVersion = this.cfg?.config?.version;
       if (currentVersion) {
-        this.hasMinMinionVersion = compareVersions(minimumVersion, currentVersion) < 0;
+        this.hasMinMinionVersion = compareVersions(currentVersion, minimumVersion) >= 0;
         if (!this.hasMinMinionVersion) {
           this.installButtonTooltip =
             'This product version cannot be applied because it requires a BDeploy version of ' +

ui/webapp/src/app/modules/primary/instances/components/dashboard/dashboard.component.ts

@@ -176,7 +176,7 @@ export class DashboardComponent implements OnInit, OnDestroy {
         if (minimumVersion) {
           const currentVersion = this.cfg?.config?.version;
           if (currentVersion) {
-            if (compareVersions(minimumVersion, currentVersion) < 0) {
+            if (compareVersions(currentVersion, minimumVersion) >= 0) {
               this.hasMinMinionVersion.set(true);
               this.installButtonDisabledMessage.set(null);
             } else {