Fix docs dependencies spec, resolve docs version automatically #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snejus
requested review from
sampsyo and
semohr
and removed request for
sampsyo
semohr
reviewed
Oct 27, 2025
|
|
||
| MATCH_VERSION_LINE = re.compile(r"version = \W((\d+\.\d+)\.\d.*?)\W").fullmatch | ||
|
|
||
| pyproject = Path(__file__).parent.parent / "pyproject.toml" |
Contributor
There was a problem hiding this comment.
We should consider using tomllib for this instead. Was only added recently in python 3.11 tho.
Member
Author
There was a problem hiding this comment.
I thought so too, but did not want to add a dependency for Python < 3.11 for such a small task
semohr
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof it works: