refactor: omit unnecessary reassignment (#2994)

rifeplight · calbera · web-flow · commit 5bf596c5a4d0 · 2025-12-04T20:52:21.000Z
Signed-off-by: rifeplight &lt;rifeplight@outlook.com&gt;
Co-authored-by: Cal Bera &lt;calbera@berachain.com&gt;
diff --git a/consensus-types/types/consolidation_request_test.go b/consensus-types/types/consolidation_request_test.go
@@ -113,7 +113,6 @@ func TestConsolidationRequest_ValidValuesSSZ(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
diff --git a/consensus-types/types/deposit_request_test.go b/consensus-types/types/deposit_request_test.go
@@ -169,7 +169,6 @@ func TestDepositRequest_ValidValuesSSZ(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -322,7 +321,6 @@ func TestDepositRequests_ValidValuesSSZ(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
diff --git a/consensus-types/types/execution_requests_test.go b/consensus-types/types/execution_requests_test.go
@@ -211,7 +211,6 @@ func TestExecutionRequests_ValidValuesSSZ(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
diff --git a/consensus-types/types/pending_partial_withdrawal_test.go b/consensus-types/types/pending_partial_withdrawal_test.go
@@ -71,7 +71,6 @@ func TestPendingPartialWithdrawal_ValidValuesSSZ(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -183,7 +182,6 @@ func TestPendingPartialWithdrawals_ValidValuesSSZ(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
diff --git a/consensus-types/types/withdrawals_request_test.go b/consensus-types/types/withdrawals_request_test.go
@@ -111,7 +111,6 @@ func TestWithdrawalRequest_ValidValuesSSZ(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
diff --git a/node-api/handlers/beacon/blob_test.go b/node-api/handlers/beacon/blob_test.go
@@ -103,7 +103,6 @@ func TestGetBlobSidecars(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
diff --git a/node-api/handlers/beacon/randao_test.go b/node-api/handlers/beacon/randao_test.go
@@ -126,7 +126,6 @@ func TestGetRandao(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			// setup test
 			backend := mocks.NewBackend(t)
diff --git a/node-api/handlers/beacon/validators_balances_test.go b/node-api/handlers/beacon/validators_balances_test.go
@@ -208,7 +208,6 @@ func TestGetStateValidatorBalances(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			// setup test
 			backend := mocks.NewBackend(t)
diff --git a/node-api/handlers/beacon/validators_filters_test.go b/node-api/handlers/beacon/validators_filters_test.go
@@ -306,7 +306,6 @@ func TestFilterValidators(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			// setup test
 			backend := mocks.NewBackend(t)
diff --git a/node-api/handlers/beacon/validators_test.go b/node-api/handlers/beacon/validators_test.go
@@ -140,7 +140,6 @@ func TestGetValidator(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			// setup test
 			backend := mocks.NewBackend(t)
diff --git a/node-api/handlers/beacon/withdrawal_test.go b/node-api/handlers/beacon/withdrawal_test.go
@@ -157,7 +157,6 @@ func TestGetPendingPartialWithdrawals(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			// setup test
 			backend := mocks.NewBackend(t)

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,6 @@ func TestConsolidationRequest_ValidValuesSSZ(t *testing.T) {`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`for _, tc := range testCases {`
`116`		`- tc := tc // capture range variable`
`117`	`116`	`t.Run(tc.name, func(t *testing.T) {`
`118`	`117`	`t.Parallel()`
`119`	`118`
Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,6 @@ func TestDepositRequest_ValidValuesSSZ(t *testing.T) {`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`for _, tc := range testCases {`
`172`		`- tc := tc // capture range variable`
`173`	`172`	`t.Run(tc.name, func(t *testing.T) {`
`174`	`173`	`t.Parallel()`
`175`	`174`
`@@ -322,7 +321,6 @@ func TestDepositRequests_ValidValuesSSZ(t *testing.T) {`
`322`	`321`	`}`
`323`	`322`
`324`	`323`	`for _, tc := range testCases {`
`325`		`- tc := tc // capture range variable`
`326`	`324`	`t.Run(tc.name, func(t *testing.T) {`
`327`	`325`	`t.Parallel()`
`328`	`326`
Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,6 @@ func TestExecutionRequests_ValidValuesSSZ(t *testing.T) {`
`211`	`211`	`}`
`212`	`212`
`213`	`213`	`for _, tc := range testCases {`
`214`		`- tc := tc // capture range variable`
`215`	`214`	`t.Run(tc.name, func(t *testing.T) {`
`216`	`215`	`t.Parallel()`
`217`	`216`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,6 @@ func TestPendingPartialWithdrawal_ValidValuesSSZ(t *testing.T) {`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`for _, tc := range testCases {`
`74`		`- tc := tc // capture range variable`
`75`	`74`	`t.Run(tc.name, func(t *testing.T) {`
`76`	`75`	`t.Parallel()`
`77`	`76`
`@@ -183,7 +182,6 @@ func TestPendingPartialWithdrawals_ValidValuesSSZ(t *testing.T) {`
`183`	`182`	`}`
`184`	`183`
`185`	`184`	`for _, tc := range testCases {`
`186`		`- tc := tc // capture range variable`
`187`	`185`	`t.Run(tc.name, func(t *testing.T) {`
`188`	`186`	`t.Parallel()`
`189`	`187`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,6 @@ func TestWithdrawalRequest_ValidValuesSSZ(t *testing.T) {`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`for _, tc := range testCases {`
`114`		`- tc := tc // capture range variable`
`115`	`114`	`t.Run(tc.name, func(t *testing.T) {`
`116`	`115`	`t.Parallel()`
`117`	`116`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,6 @@ func TestGetBlobSidecars(t *testing.T) {`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`for _, tc := range testCases {`
`106`		`- tc := tc // capture range variable`
`107`	`106`	`t.Run(tc.name, func(t *testing.T) {`
`108`	`107`	`t.Parallel()`
`109`	`108`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,6 @@ func TestGetRandao(t *testing.T) {`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`for _, tc := range testCases {`
`129`		`- tc := tc // capture range variable`
`130`	`129`	`t.Run(tc.name, func(t *testing.T) {`
`131`	`130`	`// setup test`
`132`	`131`	`backend := mocks.NewBackend(t)`
Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,6 @@ func TestGetStateValidatorBalances(t *testing.T) {`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`for _, tc := range testCases {`
`211`		`- tc := tc // capture range variable`
`212`	`211`	`t.Run(tc.name, func(t *testing.T) {`
`213`	`212`	`// setup test`
`214`	`213`	`backend := mocks.NewBackend(t)`
Original file line number	Diff line number	Diff line change
`@@ -306,7 +306,6 @@ func TestFilterValidators(t *testing.T) {`
`306`	`306`	`}`
`307`	`307`
`308`	`308`	`for _, tc := range testCases {`
`309`		`- tc := tc // capture range variable`
`310`	`309`	`t.Run(tc.name, func(t *testing.T) {`
`311`	`310`	`// setup test`
`312`	`311`	`backend := mocks.NewBackend(t)`
Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,6 @@ func TestGetValidator(t *testing.T) {`
`140`	`140`	`}`
`141`	`141`
`142`	`142`	`for _, tc := range testCases {`
`143`		`- tc := tc // capture range variable`
`144`	`143`	`t.Run(tc.name, func(t *testing.T) {`
`145`	`144`	`// setup test`
`146`	`145`	`backend := mocks.NewBackend(t)`