-
Notifications
You must be signed in to change notification settings - Fork 207
add TBS_LUCID_PRO_FC_V2 #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a new board configuration header for TBS_LUCID_PRO_FC_V2 flight controller with AT32F435M MCU. Defines hardware feature support, comprehensive pin mappings for motors, servos, sensors, UARTs, I2C, SPI interfaces, timer configurations, peripheral instances, and default settings for blackbox, meters, and serial receiver. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (14)📓 Common learnings📚 Learning: 2025-07-03T04:33:57.480ZApplied to files:
📚 Learning: 2025-07-14T16:16:56.822ZApplied to files:
📚 Learning: 2025-07-03T04:33:57.480ZApplied to files:
📚 Learning: 2025-06-23T18:43:31.746ZApplied to files:
📚 Learning: 2025-08-22T17:08:23.283ZApplied to files:
📚 Learning: 2025-07-23T13:43:50.456ZApplied to files:
📚 Learning: 2025-07-23T13:43:50.456ZApplied to files:
📚 Learning: 2025-07-28T16:44:59.686ZApplied to files:
📚 Learning: 2025-07-03T15:17:30.040ZApplied to files:
📚 Learning: 2025-08-20T02:54:58.596ZApplied to files:
📚 Learning: 2025-06-02T16:16:20.197ZApplied to files:
📚 Learning: 2025-08-28T20:45:36.652ZApplied to files:
📚 Learning: 2025-08-28T20:45:36.652ZApplied to files:
🔇 Additional comments (5)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| #define LED0_PIN PC14 | ||
| #define LED1_PIN PC15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not follow design guidelines.
Checkout https://www.betaflight.com/docs/development/manufacturer/manufacturer-design-guidelines#3146-leds
| #define DEFAULT_ALIGN_BOARD_ROLL 180 | ||
| #define DEFAULT_ALIGN_BOARD_YAW 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean
| #define DEFAULT_ALIGN_BOARD_ROLL 180 | |
| #define DEFAULT_ALIGN_BOARD_YAW 0 | |
| #define GYRO_1_ALIGN CW0_DEG_FLIP |
| #define ADC1_DMA_OPT 0 | ||
| #define SPI3_TX_DMA_OPT 5 | ||
|
|
||
| #define ADC_INSTANCE ADC1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ADC1 is default instance.
| #define ADC_INSTANCE ADC1 |
| #define MOTOR1_PIN PC6 | ||
| #define MOTOR2_PIN PB5 | ||
| #define MOTOR3_PIN PC8 | ||
| #define MOTOR4_PIN PC9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not follow design guidelines
See: https://www.betaflight.com/docs/development/manufacturer/manufacturer-design-guidelines#32-resource-selection-considerations
|
Will re-submit once we have incorporated the feedback. |
New revision of the Lucid Pro redesigned layer stack for better electrical characteristics, no pinout changes, but gyro orientation changed.
Summary by CodeRabbit