build: align node version with nx compatibility matrix (#530)

Nx has a NodeJS and TypeScript Compatibility Matrix. We are dropping the multiple NodeJS support
versions. From now on, we will align to the NodeJs Compatibility Matrix

BREAKING CHANGE: drop support to node V16

Author: dianjuar

.github/actions/setup/action.yml

@@ -1,10 +1,5 @@
 name: Setup
 description: Setup Node.js, cache and install dependencies
-inputs:
-  node-version:
-    description: Node.js version
-    required: false
-    default: '16'
 runs:
   using: composite
   steps:
@@ -15,8 +10,8 @@ runs:
     - name: Use Node.js
       uses: actions/setup-node@v3
       with:
+        node-version-file: '.nvmrc'
         cache: 'npm'
-        node-version: ${{ inputs.node-version }}
         # This doesn't just set the registry url, but also sets
         # the right configuration in .npmrc that reads NPM token
         # from NPM_AUTH_TOKEN environment variable.

.github/workflows/angular-e2e-test.yml

@@ -5,16 +5,11 @@ on: workflow_call
 jobs:
   angular-e2e-test:
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        node-version: [16, 18]
     steps:
       - uses: actions/checkout@v3
         with:
           fetch-depth: 0
       - uses: ./.github/actions/setup
-        with:
-          node-version: ${{ matrix.node-version }}
 
       - uses: ./.github/actions/download-build
 

.github/workflows/basic-test.yml

@@ -51,21 +51,17 @@ jobs:
   unit-test:
     strategy:
       matrix:
-        node-version: [16, 18]
         os: [ubuntu-latest, windows-latest]
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3
         with:
           fetch-depth: 0
       - uses: ./.github/actions/setup
-        with:
-          node-version: ${{ matrix.node-version }}
 
       - run: npx nx test --code-coverage
 
-      - if: matrix.node-version == 18 && inputs.reports == true
-        name: Archive coverage report
+      - name: Archive coverage report
         uses: actions/upload-artifact@v3
         with:
           name: ngx-deploy-npm-coverage-report-${{ github.sha }}

.github/workflows/e2e-test.yml

@@ -6,15 +6,12 @@ jobs:
   e2e-test:
     strategy:
       matrix:
-        node-version: [16, 18]
         os: [ubuntu-latest, windows-latest]
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3
         with:
           fetch-depth: 0
       - uses: ./.github/actions/setup
-        with:
-          node-version: ${{ matrix.node-version }}
 
       - run: npx nx e2e ngx-deploy-npm-e2e

.github/workflows/integration-test.yml

@@ -5,16 +5,11 @@ on: workflow_call
 jobs:
   integration-test:
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        node-version: [16, 18]
     steps:
       - uses: actions/checkout@v3
         with:
           fetch-depth: 0
       - uses: ./.github/actions/setup
-        with:
-          node-version: ${{ matrix.node-version }}
 
       - name: Integration Test
         run: npx nx e2e ngx-deploy-npm-e2e --jestConfig e2e/ngx-deploy-npm-e2e/jest.integration.config.js

.nvmrc

@@ -1 +1 @@
-16
+18

README.md

@@ -1,6 +1,7 @@
 # ngx-deploy-npm 🚀 <!-- omit in toc -->
 
-![Node version][supported-node-versions]
+<!-- [![Nx supported versions][supported-nx-versions]][nx-url] -->
+
 [![NPM version][npm-image]][npm-url]
 [![NPM donwoads][downloads-image]][npm-url]
 [![The MIT License][mit-licence-image]][mit-licence-url]
@@ -24,7 +25,7 @@
 [![Next JS][next-js-image]][next-js-link]
 [![Node][node-image]][node-link]
 [![JS][js-image]][js-link]
-[![Nx Plugin][nx-image]][nx-link]
+[![Nx Plugin][nx-image]][nx-plugin-link]
 [![React][react-image]][react-link]
 [![React Native][react-native-image]][react-native-link]
 
@@ -38,7 +39,7 @@
 [mit-licence-image]: https://img.shields.io/badge/license-MIT-orange.svg?color=blue&style=flat
 [conventional-commits-image]: https://img.shields.io/badge/Conventional%20Commits-1.0.0-yellow.svg
 [downloads-image]: https://img.shields.io/npm/dm/ngx-deploy-npm
-[supported-node-versions]: https://img.shields.io/badge/node-v16%20v18-green
+[supported-nx-versions]: https://img.shields.io/badge/nx%20supported%20versions-v16-143055
 [next-tests-image]: https://github.com/bikecoders/ngx-deploy-npm/actions/workflows/test-nx-next.yml/badge.svg
 [linux-image]: https://img.shields.io/badge/Linux-FCC624?style=flat&logo=linux&logoColor=black
 [macos-image]: https://img.shields.io/badge/mac%20os-000000?style=flat&logo=macos&logoColor=F0F0F0
@@ -63,6 +64,7 @@
 [mit-licence-url]: http://opensource.org/licenses/MIT
 [conventional-commits-url]: https://conventionalcommits.org
 [next-tests-link]: https://github.com/bikecoders/ngx-deploy-npm/actions/workflows/test-nx-next.yml
+[nx-url]: https://nx.dev/
 
 <!-- Projects -->
 
@@ -71,7 +73,7 @@
 [next-js-link]: https://nx.dev/packages/next
 [node-link]: https://nx.dev/packages/node
 [js-link]: https://nx.dev/packages/js
-[nx-link]: https://nx.dev/packages/nx-plugin
+[nx-plugin-link]: https://nx.dev/packages/nx-plugin
 [react-link]: https://nx.dev/packages/react
 [react-native-link]: https://nx.dev/packages/react-native