Skip to content

Commit a6e5115

Browse files
committed
fix memory leak by re-using the global instance
1 parent 4e7bac0 commit a6e5115

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

app/src/debug/kotlin/de/binarynoise/captiveportalautologin/gecko/GeckoViewActivity.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package de.binarynoise.captiveportalautologin.gecko
33
import kotlin.concurrent.read
44
import kotlin.concurrent.write
55
import android.content.Intent
6-
import android.net.ConnectivityManager
76
import android.net.Network
87
import android.os.Bundle
98
import android.os.Handler
@@ -14,10 +13,10 @@ import android.view.MenuItem
1413
import android.widget.Toast
1514
import androidx.activity.ComponentActivity
1615
import androidx.annotation.UiThread
17-
import androidx.core.content.ContextCompat
1816
import androidx.core.view.isVisible
1917
import by.kirich1409.viewbindingdelegate.viewBinding
2018
import de.binarynoise.captiveportalautologin.BuildConfig
19+
import de.binarynoise.captiveportalautologin.ConnectivityChangeListenerService.Companion.connectivityManager
2120
import de.binarynoise.captiveportalautologin.ConnectivityChangeListenerService.Companion.networkListeners
2221
import de.binarynoise.captiveportalautologin.ConnectivityChangeListenerService.Companion.networkState
2322
import de.binarynoise.captiveportalautologin.ConnectivityChangeListenerService.Companion.networkStateLock
@@ -166,8 +165,6 @@ class GeckoViewActivity : ComponentActivity() {
166165
menuItem.setOnMenuItemClickListener {
167166
networkStateLock.write {
168167
networkState = networkState?.copy(debug = true) ?: run {
169-
val connectivityManager =
170-
ContextCompat.getSystemService(this, ConnectivityManager::class.java)!!
171168
val network = connectivityManager.activeNetwork ?: Network.CREATOR.createFromParcel(
172169
Parcel.obtain().apply { writeInt(-1) })
173170
NetworkState(

0 commit comments

Comments
 (0)