Merge pull request #28 from bitflow-stream/anton-log-Jenkings-test-output

Duplicating the test output to stderr to make it visible in the Jenkins log

Author: alek-thunder

Jenkinsfile

@@ -27,7 +27,7 @@ pipeline {
                     sh 'go clean -i -v ./...'
                     sh 'go install -v ./...'
                     sh 'rm -rf reports && mkdir -p reports'
-                    sh 'go test -v ./... -coverprofile=reports/test-coverage.txt 2>&1 | go-junit-report > reports/test.xml'
+                    sh 'go test -v ./... -coverprofile=reports/test-coverage.txt | tee /dev/stderr | go-junit-report -set-exit-code > reports/test.xml'
                     sh 'go vet ./... &> reports/vet.txt'
                     sh 'golint $(go list -f "{{.Dir}}" ./...) &> reports/lint.txt'
             }

bitflow/transport_tcp_test.go

@@ -1,6 +1,8 @@
 package bitflow
 
 import (
+	"net"
+	"strconv"
 	"sync"
 	"testing"
 	"time"
@@ -10,6 +12,23 @@ import (
 	"github.com/stretchr/testify/suite"
 )
 
+func GetLocalPort() string {
+	addr, err := net.ResolveTCPAddr("tcp", "localhost:0")
+	if err != nil {
+		panic(err)
+	}
+	l, err := net.ListenTCP("tcp", addr)
+	if err != nil {
+		panic(err)
+	}
+	defer func() {
+		if closeErr := l.Close(); closeErr != nil {
+			panic(closeErr)
+		}
+	}()
+	return strconv.Itoa(l.Addr().(*net.TCPAddr).Port)
+}
+
 type TcpListenerTestSuite struct {
 	testSuiteWithSamples
 }
@@ -35,17 +54,18 @@ func (suite *TcpListenerTestSuite) runGroup(sender golib.Task, generator SampleP
 
 func (suite *TcpListenerTestSuite) testListenerSinkAll(m BidiMarshaller) {
 	testSink := suite.newFilledTestSink()
+	port := GetLocalPort()
 
 	l := &TCPListenerSink{
-		Endpoint:        ":7878",
+		Endpoint:        ":" + port,
 		BufferedSamples: 100,
 	}
 	l.Writer.ParallelSampleHandler = parallel_handler
 	l.SetMarshaller(m)
 
 	s := &TCPSource{
 		PrintErrors:   true,
-		RemoteAddrs:   []string{"localhost:7878"},
+		RemoteAddrs:   []string{"localhost:" + port},
 		RetryInterval: time.Second,
 		DialTimeout:   tcp_dial_timeout,
 	}
@@ -69,19 +89,20 @@ func (suite *TcpListenerTestSuite) testListenerSinkAll(m BidiMarshaller) {
 func (suite *TcpListenerTestSuite) testListenerSinkIndividual(m Marshaller) {
 	for i := range suite.headers {
 		testSink := suite.newTestSinkFor(i)
+		port := GetLocalPort()
 
 		// TODO test that a smaller buffer leads to dropped samples
 
 		l := &TCPListenerSink{
-			Endpoint:        ":7878",
+			Endpoint:        ":" + port,
 			BufferedSamples: 100,
 		}
 		l.Writer.ParallelSampleHandler = parallel_handler
 		l.SetMarshaller(m)
 
 		s := &TCPSource{
 			PrintErrors:   true,
-			RemoteAddrs:   []string{"localhost:7878"},
+			RemoteAddrs:   []string{"localhost:" + port},
 			RetryInterval: tcp_download_retry_interval,
 			DialTimeout:   tcp_dial_timeout,
 		}
@@ -121,14 +142,15 @@ func (suite *TcpListenerTestSuite) TestListenerSinkAllBinary() {
 
 func (suite *TcpListenerTestSuite) testListenerSourceAll(m Marshaller) {
 	testSink := suite.newFilledTestSink()
+	port := GetLocalPort()
 
-	l := NewTcpListenerSource(":7878")
+	l := NewTcpListenerSource(":" + port)
 	l.Reader = SampleReader{
 		ParallelSampleHandler: parallel_handler,
 	}
 
 	s := &TCPSink{
-		Endpoint:    "localhost:7878",
+		Endpoint:    "localhost:" + port,
 		DialTimeout: tcp_dial_timeout,
 	}
 	s.Writer.ParallelSampleHandler = parallel_handler
@@ -152,14 +174,15 @@ func (suite *TcpListenerTestSuite) testListenerSourceAll(m Marshaller) {
 func (suite *TcpListenerTestSuite) testListenerSourceIndividual(m BidiMarshaller) {
 	for i := range suite.headers {
 		testSink := suite.newTestSinkFor(i)
+		port := GetLocalPort()
 
-		l := NewTcpListenerSource(":7878")
+		l := NewTcpListenerSource(":" + port)
 		l.Reader = SampleReader{
 			ParallelSampleHandler: parallel_handler,
 		}
 
 		s := &TCPSink{
-			Endpoint:    "localhost:7878",
+			Endpoint:    "localhost:" + port,
 			DialTimeout: tcp_dial_timeout,
 		}
 		s.Writer.ParallelSampleHandler = parallel_handler