Skip to content

Conversation

@nick-livefront
Copy link
Contributor

@nick-livefront nick-livefront commented Nov 11, 2025

🎟️ Tracking

PM-25081
Client Side: bitwarden/clients#17337

📔 Objective

Add pm-25081-vault-skeleton-loaders feature flag

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@claude
Copy link

claude bot commented Nov 11, 2025

Claude finished @nick-livefront's task —— View job


Code Review Complete

Clean implementation of a feature flag constant.

Findings

⚠️ Finding 1: Feature flag ordering inconsistency in src/Core/Constants.cs:255


public const string PM22136_SdkCipherEncryption = "pm-22136-sdk-cipher-encryption";
public const string PM23904_RiskInsightsForPremium = "pm-23904-risk-insights-for-premium";
public const string PM25083_AutofillConfirmFromSearch = "pm-25083-autofill-confirm-from-search";
public const string VaultLoadingSkeletons = "pm-25081-vault-skeleton-loaders";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This feature flag should be placed before PM25083_AutofillConfirmFromSearch (line 254) to maintain numerical ordering by PM number. The current placement has PM-25081 after PM-25083, which breaks the ascending order pattern used in this section.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailse20f0090-3978-42ef-8943-675f781263a8

Great job! No new security vulnerabilities introduced in this pull request

@nick-livefront nick-livefront merged commit ea23358 into main Nov 11, 2025
45 checks passed
@nick-livefront nick-livefront deleted the skeleton-feature-flag branch November 11, 2025 20:29
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.77%. Comparing base (db36c52) to head (0a95d10).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6566      +/-   ##
==========================================
- Coverage   52.77%   52.77%   -0.01%     
==========================================
  Files        1910     1910              
  Lines       84843    84843              
  Branches     7576     7576              
==========================================
- Hits        44780    44777       -3     
- Misses      38328    38330       +2     
- Partials     1735     1736       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants