Replace rake task puts with logger commands (#1215)

Author: farhatahmad

lib/tasks/liveness.rake

@@ -2,5 +2,5 @@
 
 desc('livenessProbe')
 task liveness: :environment do
-  puts 'success'
+  Rails.logger.info('success')
 end

lib/tasks/meetings.rake

@@ -21,13 +21,13 @@ task :meetings, [:meeting_ids] => :environment do |_t, args|
       response = get_post_req(encode_bbb_uri('getMeetingInfo', meeting_server.url,
                                              meeting_server.secret, meetingID: meeting.id))
       meeting_id = response.xpath('/response/meetingID').text
-      puts("\nMeetingID: #{meeting_id}")
-      puts("\tServer ID: #{meeting_server.id}")
-      puts("\tServer Url: #{meeting_server.url}")
+      Rails.logger.info("\nMeetingID: #{meeting_id}")
+      Rails.logger.info("\tServer ID: #{meeting_server.id}")
+      Rails.logger.info("\tServer Url: #{meeting_server.url}")
     rescue BBBErrors::BBBError => e
-      puts("\nFailed to get meeting id=#{meeting.id} status: #{e}")
+      Rails.logger.error("\nFailed to get meeting id=#{meeting.id} status: #{e}")
     rescue StandardError => e
-      puts("\nFailed to get meetings list status: #{e}")
+      Rails.logger.error("\nFailed to get meetings list status: #{e}")
     end
   end
   begin
@@ -44,8 +44,8 @@ namespace :meetings do
   desc('End all/specific meetings running in BigBlueButton servers')
   task :end, [:meeting_ids] => :environment do |_t, args|
     $stdout.sync = true
-    puts('WARNING: You are trying to clear active meetings.')
-    puts('If you still wish to continue please enter `yes`')
+    Rails.logger.info('WARNING: You are trying to clear active meetings.')
+    Rails.logger.info('If you still wish to continue please enter `yes`')
     response = $stdin.gets.chomp.casecmp('yes').zero?
     if response
       args.with_defaults(meeting_ids: '')
@@ -57,7 +57,7 @@ namespace :meetings do
                  else
                    Meeting.all
                  end
-      puts('No meetings to clear') if meetings.empty?
+      Rails.logger.info('No meetings to clear') if meetings.empty?
       pool = Concurrent::FixedThreadPool.new(Rails.configuration.x.poller_threads.to_i - 1, name: 'end-meeting')
       tasks = meetings.map do |meeting|
         Concurrent::Promises.future_on(pool) do
@@ -66,11 +66,11 @@ namespace :meetings do
           meeting.destroy!
           get_post_req(encode_bbb_uri('end', meeting_server.url, meeting_server.secret,
                                       meetingID: meeting.id, password: moderator_pw))
-          puts("Clearing Meeting id=#{meeting.id}")
+          Rails.logger.info("Clearing Meeting id=#{meeting.id}")
         rescue ApplicationRedisRecord::RecordNotDestroyed => e
           raise("ERROR: Could not destroy meeting id=#{meeting.id}: #{e}")
         rescue StandardError => e
-          puts("WARNING: Could not end meeting id=#{meeting.id}: #{e}")
+          Rails.logger.error("WARNING: Could not end meeting id=#{meeting.id}: #{e}")
         end
       end
       begin
@@ -81,45 +81,45 @@ namespace :meetings do
       pool.shutdown
       pool.wait_for_termination(5) || pool.kill
     end
-    puts('OK')
+    Rails.logger.info('OK')
   end
 
   desc('Get meeting details running in BigBlueButton servers')
   task :info, [:meeting_id] => :environment do |_t, args|
     if args.meeting_id.nil?
-      puts('Error: Please input a meetingID!')
+      Rails.logger.error('Error: Please input a meetingID!')
       exit(1)
     end
     include ApiHelper
 
     meeting_id = args.meeting_id
     meeting = Meeting.find(meeting_id)
-    puts('No meeting info to show') if meeting.nil?
+    Rails.logger.info('No meeting info to show') if meeting.nil?
     meeting_server = meeting.server
     response = get_post_req(encode_bbb_uri('getMeetingInfo', meeting_server.url,
                                            meeting_server.secret, meetingID: meeting.id))
-    puts("\nMeeting ID: #{response.xpath('/response/meetingID').text}")
-    puts("\tMeeting Name: #{response.xpath('/response/meetingName').text}")
-    puts("\tInternal MeetingID: #{response.xpath('/response/internalMeetingID').text}")
-    puts("\tCreated Date: #{response.xpath('/response/createDate').text}")
-    puts("\tRecording Enabled: #{response.xpath('/response/recording').text}")
-    puts("\tServer id: #{meeting_server.id}")
-    puts("\tSerevr url: #{meeting_server.url}")
+    Rails.logger.info("\nMeeting ID: #{response.xpath('/response/meetingID').text}")
+    Rails.logger.info("\tMeeting Name: #{response.xpath('/response/meetingName').text}")
+    Rails.logger.info("\tInternal MeetingID: #{response.xpath('/response/internalMeetingID').text}")
+    Rails.logger.info("\tCreated Date: #{response.xpath('/response/createDate').text}")
+    Rails.logger.info("\tRecording Enabled: #{response.xpath('/response/recording').text}")
+    Rails.logger.info("\tServer id: #{meeting_server.id}")
+    Rails.logger.info("\tSerevr url: #{meeting_server.url}")
     metadata = response.xpath('/response/metadata')
-    puts("\tMetaData:")
-    puts("\t\tbbb-context-name: #{metadata.xpath('.//bbb-context-name').text}")
-    puts("\t\tanalytics-callback-url: #{metadata.xpath('.//analytics-callback-url').text}")
-    puts("\t\tbbb-recording-tags: #{metadata.xpath('.//bbb-recording-tags').text}")
-    puts("\t\tbbb-origin-server-common-name: #{metadata.xpath('.//bbb-origin-server-common-name').text}")
-    puts("\t\tbbb-context-label: #{metadata.xpath('.//bbb-context-label').text}")
-    puts("\t\tbbb-origin: #{metadata.xpath('.//bbb-context-name').text}")
-    puts("\t\tbbb-context: #{metadata.xpath('.//bbb-context').text}")
-    puts("\t\tbbb-context-id: #{metadata.xpath('.//bbb-context-id').text}")
-    puts("\t\tbbb-recording-name: #{metadata.xpath('.//bbb-recording-name').text}")
-    puts("\t\tbbb-origin-server-name: #{metadata.xpath('.//bbb-origin-server-name').text}")
-    puts("\t\tbbb-recording-description: #{metadata.xpath('.//bbb-recording-description').text}")
-    puts("\t\tbbb-origin-tag: #{metadata.xpath('.//bbb-origin-tag').text}")
+    Rails.logger.info("\tMetaData:")
+    Rails.logger.info("\t\tbbb-context-name: #{metadata.xpath('.//bbb-context-name').text}")
+    Rails.logger.info("\t\tanalytics-callback-url: #{metadata.xpath('.//analytics-callback-url').text}")
+    Rails.logger.info("\t\tbbb-recording-tags: #{metadata.xpath('.//bbb-recording-tags').text}")
+    Rails.logger.info("\t\tbbb-origin-server-common-name: #{metadata.xpath('.//bbb-origin-server-common-name').text}")
+    Rails.logger.info("\t\tbbb-context-label: #{metadata.xpath('.//bbb-context-label').text}")
+    Rails.logger.info("\t\tbbb-origin: #{metadata.xpath('.//bbb-context-name').text}")
+    Rails.logger.info("\t\tbbb-context: #{metadata.xpath('.//bbb-context').text}")
+    Rails.logger.info("\t\tbbb-context-id: #{metadata.xpath('.//bbb-context-id').text}")
+    Rails.logger.info("\t\tbbb-recording-name: #{metadata.xpath('.//bbb-recording-name').text}")
+    Rails.logger.info("\t\tbbb-origin-server-name: #{metadata.xpath('.//bbb-origin-server-name').text}")
+    Rails.logger.info("\t\tbbb-recording-description: #{metadata.xpath('.//bbb-recording-description').text}")
+    Rails.logger.info("\t\tbbb-origin-tag: #{metadata.xpath('.//bbb-origin-tag').text}")
   rescue StandardError => e
-    puts("WARNING: Could not get info for meeting id=#{meeting.id}: #{e}")
+    Rails.logger.error("WARNING: Could not get info for meeting id=#{meeting.id}: #{e}")
   end
 end

lib/tasks/poll.rake

@@ -99,14 +99,14 @@ namespace :poll do
 
         meetings = Meeting.all.select { |m| m.server_id == server.id }
         meetings.each do |meeting|
-          puts("Clearing Meeting id=#{meeting.id}")
+          Rails.logger.info("Clearing Meeting id=#{meeting.id}")
           moderator_pw = meeting.try(:moderator_pw)
           meeting.destroy!
           get_post_req(encode_bbb_uri('end', server.url, server.secret, meetingID: meeting.id, password: moderator_pw))
         rescue ApplicationRedisRecord::RecordNotDestroyed => e
           raise("ERROR: Could not destroy meeting id=#{meeting.id}: #{e}")
         rescue StandardError => e
-          puts("WARNING: Could not end meeting id=#{meeting.id}: #{e}")
+          Rails.logger.error("WARNING: Could not end meeting id=#{meeting.id}: #{e}")
         end
 
         server.reset_counters

lib/tasks/recordings.rake

@@ -49,7 +49,7 @@ namespace :recordings do
   task :addToTenant, [:tenant_id] => :environment do |_t, args|
     tenant_id = args[:tenant_id]
     unless tenant_id
-      puts('No tenant ID was provided')
+      Rails.logger.error('No tenant ID was provided')
       exit(1)
     end
 
@@ -58,10 +58,10 @@ namespace :recordings do
       begin
         Metadatum.create!(recording_id: rec.id, key: 'tenant-id', value: tenant_id)
       rescue ActiveRecord::RecordInvalid => e
-        puts("Error creating metadatum record for recording with id #{rec.id}: #{e}")
+        Rails.logger.error("Error creating metadatum record for recording with id #{rec.id}: #{e}")
       end
     end
 
-    puts("All existing recordings have been successfully linked to tenant #{tenant_id}")
+    Rails.logger.info("All existing recordings have been successfully linked to tenant #{tenant_id}")
   end
 end