fix: disable validating historical blocks

Signed-off-by: Chris Gianelloni <[email protected]>

Author: wolf31o2

database/plugin/metadata/sqlite/transaction.go

@@ -207,7 +207,10 @@ func (d *MetadataStoreSqlite) SetTransaction(
 	if tmpTx.ID == 0 {
 		existingTx, err := d.GetTransactionByHash(txHash, txn)
 		if err != nil {
-			return fmt.Errorf("failed to fetch transaction ID after upsert: %w", err)
+			return fmt.Errorf(
+				"failed to fetch transaction ID after upsert: %w",
+				err,
+			)
 		}
 		if existingTx == nil {
 			return fmt.Errorf("transaction not found after upsert: %x", txHash)

ledger/state.go

@@ -611,7 +611,6 @@ func (ls *LedgerState) ledgerProcessBlocks() {
 	var nextBatch, cachedNextBatch []ledger.Block
 	var delta *LedgerDelta
 	var deltaBatch LedgerDeltaBatch
-	shouldValidate := ls.config.ValidateHistorical
 	for {
 		if needsEpochRollover {
 			ls.Lock()
@@ -691,29 +690,31 @@ func (ls *LedgerState) ledgerProcessBlocks() {
 						nextBatch = nil
 						break
 					}
-					// Enable validation using the k-slot window from ShelleyGenesis.
-					// Only recalculate if validation is not already enabled
-					if !shouldValidate && i == 0 {
-						var cutoffSlot uint64
+					// Determine if this block should be validated
+					// Skip validation of historical blocks when ValidateHistorical=false, as they
+					// were already validated by the network. However, validate blocks within the
+					// k-slot stability window to ensure live blocks near the tip are validated.
+					var shouldValidateBlock bool
+					if ls.config.ValidateHistorical {
+						shouldValidateBlock = true
+					} else {
 						stabilityWindow := ls.calculateStabilityWindow()
 						currentTipSlot := ls.currentTip.Point.Slot
 						blockSlot := next.SlotNumber()
+						var cutoffSlot uint64
 						if currentTipSlot >= stabilityWindow {
 							cutoffSlot = currentTipSlot - stabilityWindow
 						} else {
 							cutoffSlot = 0
 						}
-
-						// Validate blocks within k-slot window, or historical blocks if ValidateHistorical enabled
-						shouldValidate = blockSlot >= cutoffSlot ||
-							ls.config.ValidateHistorical
+						shouldValidateBlock = blockSlot >= cutoffSlot
 					}
 					// Process block
 					delta, err = ls.ledgerProcessBlock(
 						txn,
 						tmpPoint,
 						next,
-						shouldValidate,
+						shouldValidateBlock,
 					)
 					if err != nil {
 						return err